Closed Bug 379284 Opened 17 years ago Closed 17 years ago

SVG "lighter" text is not lighter

Categories

(Core :: Graphics, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: codedread, Assigned: longsonr)

References

()

Details

(Keywords: regression)

Attachments

(2 files, 3 obsolete files)

See http://www.w3.org/Graphics/SVG/Test/20061213/htmlObjectHarness/full-text-fonts-02-t.html

This is a recent regression (approx 1 week).
Flags: in-testsuite?
Attached patch patch (obsolete) — Splinter Review
Attached patch diff -w patch (obsolete) — Splinter Review
Attachment #263348 - Flags: review?(vladimir)
Assignee: general → nobody
Component: SVG → GFX: Thebes
QA Contact: ian → thebes
Comment on attachment 263348 [details] [diff] [review]
patch

Looks good, thanks!  Please also create a reftest for testing the lighter keyword?
Attachment #263348 - Flags: review?(vladimir) → review+
Assignee: nobody → longsonr
Attached patch reftestSplinter Review
Attachment #263348 - Flags: superreview?(roc)
Attachment #263348 - Flags: superreview?(roc) → superreview+
Attached patch updated patch (obsolete) — Splinter Review
I was about to check this in when I managed to get a crash. This patch differs from the original patch only in that it terminates the down loop at i = 1 rather than i = 0 thus avoiding an out of array bounds access.

I'm assuming I don't need to get an sr again.
Attachment #263348 - Attachment is obsolete: true
Attachment #263349 - Attachment is obsolete: true
Attachment #265967 - Flags: review?(vladimir)
Attached patch update to tipSplinter Review
Attachment #265967 - Attachment is obsolete: true
checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Checked in reftest:
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/text-font-weight-01.svg
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: