SVG "lighter" text is not lighter

RESOLVED FIXED

Status

()

RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: codedread, Assigned: longsonr)

Tracking

({regression})

unspecified
x86
Windows XP
regression
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 3 obsolete attachments)

(Reporter)

Description

12 years ago
See http://www.w3.org/Graphics/SVG/Test/20061213/htmlObjectHarness/full-text-fonts-02-t.html

This is a recent regression (approx 1 week).

Updated

12 years ago
Flags: in-testsuite?
(Assignee)

Comment 3

12 years ago
Created attachment 263349 [details] [diff] [review]
diff -w patch
(Assignee)

Updated

12 years ago
Attachment #263348 - Flags: review?(vladimir)
(Assignee)

Updated

12 years ago
Assignee: general → nobody
Component: SVG → GFX: Thebes
QA Contact: ian → thebes
Comment on attachment 263348 [details] [diff] [review]
patch

Looks good, thanks!  Please also create a reftest for testing the lighter keyword?
Attachment #263348 - Flags: review?(vladimir) → review+
(Assignee)

Updated

12 years ago
Assignee: nobody → longsonr
(Assignee)

Updated

12 years ago
Attachment #263348 - Flags: superreview?(roc)
Attachment #263348 - Flags: superreview?(roc) → superreview+
(Assignee)

Comment 6

12 years ago
Created attachment 265967 [details] [diff] [review]
updated patch

I was about to check this in when I managed to get a crash. This patch differs from the original patch only in that it terminates the down loop at i = 1 rather than i = 0 thus avoiding an out of array bounds access.

I'm assuming I don't need to get an sr again.
Attachment #263348 - Attachment is obsolete: true
Attachment #263349 - Attachment is obsolete: true
Attachment #265967 - Flags: review?(vladimir)
(Assignee)

Comment 7

12 years ago
Created attachment 267251 [details] [diff] [review]
update to tip
Attachment #265967 - Attachment is obsolete: true
(Assignee)

Comment 8

12 years ago
checked in.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 9

12 years ago
Checked in reftest:
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/text-font-weight-01.svg
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.