Closed
Bug 379284
Opened 17 years ago
Closed 17 years ago
SVG "lighter" text is not lighter
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: codedread, Assigned: longsonr)
References
()
Details
(Keywords: regression)
Attachments
(2 files, 3 obsolete files)
3.16 KB,
patch
|
Details | Diff | Splinter Review | |
3.33 KB,
patch
|
Details | Diff | Splinter Review |
See http://www.w3.org/Graphics/SVG/Test/20061213/htmlObjectHarness/full-text-fonts-02-t.html This is a recent regression (approx 1 week).
Comment 1•17 years ago
|
||
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1176925860&maxdate=1176931619 Must be bug 375141.
Blocks: 375141
Keywords: regression
Updated•17 years ago
|
Flags: in-testsuite?
Assignee | ||
Comment 2•17 years ago
|
||
Assignee | ||
Comment 3•17 years ago
|
||
Assignee | ||
Updated•17 years ago
|
Attachment #263348 -
Flags: review?(vladimir)
Assignee | ||
Updated•17 years ago
|
Assignee: general → nobody
Component: SVG → GFX: Thebes
QA Contact: ian → thebes
Comment on attachment 263348 [details] [diff] [review] patch Looks good, thanks! Please also create a reftest for testing the lighter keyword?
Attachment #263348 -
Flags: review?(vladimir) → review+
Assignee | ||
Updated•17 years ago
|
Assignee: nobody → longsonr
Assignee | ||
Comment 5•17 years ago
|
||
Assignee | ||
Updated•17 years ago
|
Attachment #263348 -
Flags: superreview?(roc)
Attachment #263348 -
Flags: superreview?(roc) → superreview+
Assignee | ||
Comment 6•17 years ago
|
||
I was about to check this in when I managed to get a crash. This patch differs from the original patch only in that it terminates the down loop at i = 1 rather than i = 0 thus avoiding an out of array bounds access. I'm assuming I don't need to get an sr again.
Attachment #263348 -
Attachment is obsolete: true
Attachment #263349 -
Attachment is obsolete: true
Attachment #265967 -
Flags: review?(vladimir)
Attachment #265967 -
Flags: review?(vladimir) → review+
Assignee | ||
Comment 7•17 years ago
|
||
Attachment #265967 -
Attachment is obsolete: true
Assignee | ||
Comment 8•17 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•17 years ago
|
||
Checked in reftest: http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/text-font-weight-01.svg
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•