If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

SVG "lighter" text is not lighter

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: Jeff Schiller, Assigned: Robert Longson)

Tracking

({regression})

unspecified
x86
Windows XP
regression
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 3 obsolete attachments)

(Reporter)

Description

11 years ago
See http://www.w3.org/Graphics/SVG/Test/20061213/htmlObjectHarness/full-text-fonts-02-t.html

This is a recent regression (approx 1 week).
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1176925860&maxdate=1176931619
Must be bug 375141.
Blocks: 375141
Keywords: regression
Flags: in-testsuite?
(Assignee)

Comment 2

11 years ago
Created attachment 263348 [details] [diff] [review]
patch
(Assignee)

Comment 3

11 years ago
Created attachment 263349 [details] [diff] [review]
diff -w patch
(Assignee)

Updated

11 years ago
Attachment #263348 - Flags: review?(vladimir)
(Assignee)

Updated

11 years ago
Assignee: general → nobody
Component: SVG → GFX: Thebes
QA Contact: ian → thebes
Comment on attachment 263348 [details] [diff] [review]
patch

Looks good, thanks!  Please also create a reftest for testing the lighter keyword?
Attachment #263348 - Flags: review?(vladimir) → review+
(Assignee)

Updated

11 years ago
Assignee: nobody → longsonr
(Assignee)

Comment 5

11 years ago
Created attachment 265790 [details] [diff] [review]
reftest
(Assignee)

Updated

11 years ago
Attachment #263348 - Flags: superreview?(roc)
Attachment #263348 - Flags: superreview?(roc) → superreview+
(Assignee)

Comment 6

11 years ago
Created attachment 265967 [details] [diff] [review]
updated patch

I was about to check this in when I managed to get a crash. This patch differs from the original patch only in that it terminates the down loop at i = 1 rather than i = 0 thus avoiding an out of array bounds access.

I'm assuming I don't need to get an sr again.
Attachment #263348 - Attachment is obsolete: true
Attachment #263349 - Attachment is obsolete: true
Attachment #265967 - Flags: review?(vladimir)
Attachment #265967 - Flags: review?(vladimir) → review+
(Assignee)

Comment 7

10 years ago
Created attachment 267251 [details] [diff] [review]
update to tip
Attachment #265967 - Attachment is obsolete: true
(Assignee)

Comment 8

10 years ago
checked in.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 9

10 years ago
Checked in reftest:
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/text-font-weight-01.svg
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.