Closed Bug 379314 Opened 17 years ago Closed 17 years ago

Clarify patch for bug 376328

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dveditz, Assigned: dveditz)

Details

The patch for bug 376328 was not very clear, after the release 1.8.1.4 release we can check in a clearer patch with better comments.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
Group: security
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
fixed as part of bug 386998
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
The commit http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/modules/libpr0n/decoders/icon/nsIconURI.cpp&rev=MOZILLA_1_8_BRANCH&mark=1.19.8.3
introduces a regression about moz-icon channel for linux/gtk2 (bug #225148). It makes the gtk channel inoperative.
By reverting this commit in specific, the channel worked again.
So please, review this commit and make it work with gtk2 channel too.
re-opening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Could you please a file new bug on that issue? This bug is fixed.
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
If you file a new bug, be sure to mark it "blocking" this one (and give it the "regression" keyword) so people can find the relationship to this fix.

Examples of what got broken would be good, hard to see how that patch could be harmful.

This may get fixed by bug 386998, biesi's latest patch backs out this change.
Please, forget about the above regression comments. It was our problem at packaging level. Really sorry for the noise.
You need to log in before you can comment on or make changes to this bug.