379419 - "ASSERTION: Non-border-colors case with borderColorStyleCount < 1 or > 3; what happened?" with <thead style="display: block;">

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: Non-border-colors case with borderColorStyleCount < 1 or > 3; what happened?: 'Error', file /Users/jruderman/trunk/mozilla/layout/base/nsCSSRendering.cpp, line 1835

I'm guessing this is due to bug 368247, since the assertion was added there.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

The style system is passing down NS_STYLE_BORDER_STYLE_RULES_MARKER | NS_STYLE_BORDER_STYLE_SOLID -- I'm not sure how/why STYLE_RULES_MARKER is making it down this far.  The old border code doesn't seem to have handled this at all; should I just ignore if STYLE_RULES_MARKER is set?

Comment 2

[Bernd]

STYLE_RULES_MARKER is doomed, its a ugly hack to get border collapse right. Why this is visible at all in a non BC case is beyond me. In short the fix in bug 43178 opens the road to remove this.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Do I just ignore any requests to paint with STYLE_RULES_MARKER set?  Or do I mask it out and paint as normal?

Comment 4

[Bernd]

I believe you should: mask it out and paint as normal

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Seems worth investigating why it's getting through, if it wasn't before.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

It looks like it was getting through before -- the switch statement in the old DrawSide just didn't handle any border styles that had STYLE_RULES_MARKER or'd in, and so nothing got drawn.

I'm going to take that approach as well, and just ignore any side that has STYLE_RULES_MARKER.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: ignore borders with style_rules flag

Here's the patch to just ignore anything with STYLE_RULES_MARKER set.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 264404 [details] [diff] [review]
ignore borders with style_rules flag

r+sr=dbaron

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Checked in.

Comment 10

[Jesse Ruderman]

Crashtest checked in.