379431 - Remove xpcom_obsolete from mailnews and mail

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Scott MacGregor]

Now that the filespec stuff is gone (Yay!!!)...

David do you want to remove xpcom_obsolete from mailnews and mail so we stop building and linking against xpcom_obsolete?

I think there are some thunderbird packaging changes and a change to removed-files.in we can make too.

Comment 1

[David :Bienvenu]

Not quite yet. We're still using nsIRegistry in mail/components/migration and/or mainews/import (can't remember which). I looked at replacing those methods with their NSReg equivalents, but it will take a bit of effort. 

Comment 2

[Phil Ringnalda (:philor)]

Attachment: [checked in] Something borrowed

Not yet tested, since I don't seem to have any Netscape profiles laying around, but this is basically a straight port of the Fx fix from bug 333874 (along with the bug 247427 "followup fix" to ensure we're opening something that exists, since it was there for the stealing, too).

Comment 3

[Phil Ringnalda (:philor)]

Oh, and nsIRegistry.h is included in /mailnews/base/build/nsMsgFactory.cpp, though I didn't spot why.

Comment 4

[David :Bienvenu]

Ah, bless you, Phil. That registry code was the straw that broke the camel's back - I really didn't want to deal with it :-) It looks reasonable to me.

I don't think nsMsgFactory.cpp needs that include, but I can check.

Comment 5

[David :Bienvenu]

Comment on attachment 263442 [details] [diff] [review]
[checked in] Something borrowed

looks good to me.

Comment 6

[Scott MacGregor]

Comment on attachment 263442 [details] [diff] [review]
[checked in] Something borrowed

although we may not need this anymore if we are removing support for netscape migration..

Comment 7

[Phil Ringnalda (:philor)]

I'm going to be gone all weekend, so if this is on the critical path for making things go away, I'll need someone to check it in (with the nsMsgFactory.cpp include removed, too). And unless I'm confused a different way now, we do still need it, since nsNetscapeProfileMigratorBase is providing base services, including GetProfileDataFromRegistry(), to nsSeamonkeyProfileMigrator as well.

Comment 8

[Scott MacGregor]

looks like this patch hasn't made it in yet, do you want the honors Phil?

Comment 9

[Scott MacGregor]

Attachment: [checked in]additional changes to stop building xpcom_obsolete

Once Phil's patch lands, we'll want to check this in too. It stops us from building xpcom_obsolete for Thunderbird!

I've verified with a clean tree on Windows that we successfully build without xpcom_obsolete.

Comment 10

[Phil Ringnalda (:philor)]

Comment on attachment 263442 [details] [diff] [review]
[checked in] Something borrowed

Wow, that was a *long* long weekend. I need some scheme for remembering patches on bugs I'm not assigned, where I didn't request the reviews.

Sorry for the delay, which judging by the bitrot actually made extra work for someone doing other fixes for stuff I was supposed to have removed. Oops.

mail/components/build/Makefile.in 1.14
mail/components/migration/src/Makefile.in 1.9
mail/components/migration/src/nsNetscapeProfileMigratorBase.cpp 1.8

Comment 11

[Scott MacGregor]

Comment on attachment 269441 [details] [diff] [review]
[checked in]additional changes to stop building xpcom_obsolete

I just landed this so we should no longer be building xpcom_obsolete! w00t!

Thanks for fixing the nsIRegistry stuff Phil.

Comment 12

[Mark Banner (:standard8)]

Scott, you may want to add xpcom_obsolete.xpt to removed-files as well so the updater will remove it from installed builds.

Comment 13

[Scott MacGregor]

It's already in removed-files.in:

http://mxr.mozilla.org/mozilla/source/mail/installer/removed-files.in#155

We weren't accessing any of the obsolete objects through xpconnect anymore.

:)