379433 - PangoItem and GList memory leaks in gfxPangoFonts

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Karl Tomlinson (:karlt)]

Attachment: patch to CreateGlyphRunsItemizing

gfxPangoFontGroup::CreateGlyphRunsItemizing gets a GList (items) of PangoItems
from pango_itemize but only frees the empty GList at the end of items.

This patch frees each PangoItem and the entire GList.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: patch to GetMetrics

A separate patch for similar leaks in gfxPangoFont::GetMetrics.

I assume the early return paths in GetSize and GetMetrics are not meant to be
hit?

Attachment 263238 [details] [diff] in bug 357637 removes the calls to pango_itemize in GetSize
GetMetrics so I include this patch separately as it won't be needed if the
357637 patch is landed.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 263429 [details] [diff] [review]
patch to CreateGlyphRunsItemizing

r+sr=me

Comment 3

[Mats Palmgren (inactive)]

Don't we need a pango_item_free() before the 'continue' as well?

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: patch to CreateGlyphRunsItemizing v2

Yes, thanks Mats.  Added the extra pango_item_free.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 263490 [details] [diff] [review]
patch to CreateGlyphRunsItemizing v2

Whoops, yes

Comment 6

[Nickolay_Ponomarev]

checked in "patch to CreateGlyphRunsItemizing v2":

Checking in gfxPangoFonts.cpp;
/cvsroot/mozilla/gfx/thebes/src/gfxPangoFonts.cpp,v  <--  gfxPangoFonts.cpp
new revision: 1.70; previous revision: 1.69
done


Is this FIXED or does something need to be done about the other patch?

Comment 7

[Karl Tomlinson (:karlt)]

Thanks for the checkin.  "patch to CreateGlyphRunsItemizing v2" was the checkin needed.

The remainder will be FIXED by the current patch in bug 357637.
We won't need "patch to GetMetrics" unless there is a problem with the patch in bug 357637.

Comment 8

[Karl Tomlinson (:karlt)]

Fixed with the help of attachment 263898 [details] [diff] [review] in bug 357637 now checked in.