Closed Bug 379506 Opened 17 years ago Closed 17 years ago

Integrate MochiKit Test Suite

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jeresig, Assigned: jeresig)

References

(
URL
)

Details

Attachments

(2 files, 2 obsolete files)

MochiKit Test Suite Patch
595.42 KB, patch
jeresig
: review+
Details | Diff | Splinter Review
Test Suite Fix
3.22 KB, patch
Details | Diff | Splinter Review
Attached patch MochiKit Test Suite Patch (obsolete) — — Splinter Review 
This is the integration of the MochiKit test suite into the Mozilla (and Mochitest) test suite. This test suite should not be confused with the one that currently exists in Mozilla (Mochitest), which is used as a framework for testing all other Ajax frameworks.

Specifically, this is SVN rev #1283 of the MochiKit test suite (which is much newer than the MochiKit code that's currently in place), and is meant to go along with the other Ajax libraries being tested. (This specific patch should be applied in mozilla/dom/tests/mochitest/ajax/)

This patch adds 826 new tests to the automated test suite.
Attachment #263511 - Flags: review?(sayrer)
(In reply to comment #0)
> Created an attachment (id=263511) [details]
> 
> Specifically, this is SVN rev #1283 of the MochiKit test suite (which is much
> newer than the MochiKit code that's currently in place)

OK, this patch should remove the MochiKit test pages that are in /testing/tests as well, since they contain all of the same tests.

Also, it would be good to track a release version of MochiKit. I will check the timing of the next release with Bob Ippolito.
Bob, any chance of a MochiKit release in the near future?
> OK, this patch should remove the MochiKit test pages that are in /testing/tests
> as well, since they contain all of the same tests.

I don't think that's completely necessary, considering that Mochitest (and a good number of users) still uses the old version of MochiKit (and thus, requires that the old version continue to operate correctly). We may want to consider moving that directory of tests to dom/tests/mochitest/ajax/mochikit-1.3.1 (or something similar) just so that we can have everything centralized; but we can tackle that in another ticket.

> Also, it would be good to track a release version of MochiKit. I will check the
> timing of the next release with Bob Ippolito.

Everything that I've read, including up until recently, seems to encourage users to try the latest SVN versions of MochiKit, if they wish to use any new functionality. Considering that there hasn't been a public release in over a year now, I think it's important that we begin testing something.

There's really no shame in using a non-release (especially when releases are so far apart) since we can always upgrade the test suite at a later date, so easily.
After looking at this, and talking to John, I think this looks pretty good. John says it's tested on Mac. I'm going to run it on Windows and Linux to make sure nothing explodes, but I'd like to get this running on the test machines ASAP.
PS, the biggest hurdle to this that I see is going to be keeping it up to date. John claims he used a Perl utility to convert this into our system. We should try and get that checked in as well. Also, please CC me on the bug to migrate the current suite into 1.3.1.
Comment on attachment 263511 [details] [diff] [review]
MochiKit Test Suite Patch

Sounds great Rob, I've re-flagged the patch for your review.
Attachment #263511 - Flags: review?(sayrer) → review?(rcampbell)
Comment on attachment 263511 [details] [diff] [review]
MochiKit Test Suite Patch

This checks out here (on Windows). All the tests ran through without problem. The only issue I had was with the Makefile.in patch. I think the version you patched against was slightly out-of-date. If you could resubmit with a current version, I'll check this in.
Attachment #263511 - Flags: review?(rcampbell) → review+
The only difference is that the Makefile.in diff should now not collide (Offline tests were committed recently).
Attachment #263511 - Attachment is obsolete: true
Attachment #267428 - Flags: review+
cvs commit log:

cvs -d ":ext:rcampbell%mozilla.com@cvs.mozilla.org:/cvsroot" ci -m "Bug 379506 - Integrate MochiKit Test Suite, patch by John Resig <jresig@mozilla.com>"
cvs commit: Examining .
cvs commit: Examining lib
cvs commit: Examining mochikit
cvs commit: Examining mochikit/MochiKit
cvs commit: Examining mochikit/tests
cvs commit: Examining mochikit/tests/SimpleTest
cvs commit: Examining offline
cvs commit: Examining prototype
cvs commit: Examining prototype/dist
cvs commit: Examining prototype/test
cvs commit: Examining prototype/test/lib
cvs commit: Examining prototype/test/unit
cvs commit: Examining prototype/test/unit/fixtures
Checking in Makefile.in;
/cvsroot/mozilla/dom/tests/mochitest/ajax/Makefile.in,v  <--  Makefile.in
new revision: 1.3; previous revision: 1.2
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/Makefile.in,v
done
Checking in mochikit/Makefile.in;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/Makefile.in,v  <--  Makefile.in
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/manifest.json,v
done
Checking in mochikit/manifest.json;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/manifest.json,v  <--  manifest.json
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/test_Mochikit.html,v
done
Checking in mochikit/test_Mochikit.html;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/test_Mochikit.html,v  <--  test_Mochikit.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Async.js,v
done
Checking in mochikit/MochiKit/Async.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Async.js,v  <--  Async.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Base.js,v
done
Checking in mochikit/MochiKit/Base.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Base.js,v  <--  Base.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Color.js,v
done
Checking in mochikit/MochiKit/Color.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Color.js,v  <--  Color.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Controls.js,v
done
Checking in mochikit/MochiKit/Controls.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Controls.js,v  <--  Controls.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/DOM.js,v
done
Checking in mochikit/MochiKit/DOM.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/DOM.js,v  <--  DOM.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/DateTime.js,v
done
Checking in mochikit/MochiKit/DateTime.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/DateTime.js,v  <--  DateTime.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/DragAndDrop.js,v
done
Checking in mochikit/MochiKit/DragAndDrop.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/DragAndDrop.js,v  <--  DragAndDrop.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Format.js,v
done
Checking in mochikit/MochiKit/Format.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Format.js,v  <--  Format.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Iter.js,v
done
Checking in mochikit/MochiKit/Iter.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Iter.js,v  <--  Iter.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Logging.js,v
done
Checking in mochikit/MochiKit/Logging.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Logging.js,v  <--  Logging.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/LoggingPane.js,v
done
Checking in mochikit/MochiKit/LoggingPane.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/LoggingPane.js,v  <--  LoggingPane.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Makefile.in,v
done
Checking in mochikit/MochiKit/Makefile.in;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Makefile.in,v  <--  Makefile.in
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/MochiKit.js,v
done
Checking in mochikit/MochiKit/MochiKit.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/MochiKit.js,v  <--  MochiKit.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/MockDOM.js,v
done
Checking in mochikit/MochiKit/MockDOM.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/MockDOM.js,v  <--  MockDOM.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Position.js,v
done
Checking in mochikit/MochiKit/Position.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Position.js,v  <--  Position.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Selector.js,v
done
Checking in mochikit/MochiKit/Selector.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Selector.js,v  <--  Selector.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Signal.js,v
done
Checking in mochikit/MochiKit/Signal.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Signal.js,v  <--  Signal.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Sortable.js,v
done
Checking in mochikit/MochiKit/Sortable.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Sortable.js,v  <--  Sortable.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Style.js,v
done
Checking in mochikit/MochiKit/Style.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Style.js,v  <--  Style.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Test.js,v
done
Checking in mochikit/MochiKit/Test.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Test.js,v  <--  Test.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Visual.js,v
done
Checking in mochikit/MochiKit/Visual.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Visual.js,v  <--  Visual.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/__package__.js,v
done
Checking in mochikit/MochiKit/__package__.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/__package__.js,v  <--  __package__.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/FakeJSAN.js,v
done
Checking in mochikit/tests/FakeJSAN.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/FakeJSAN.js,v  <--  FakeJSAN.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/Makefile.in,v
done
Checking in mochikit/tests/Makefile.in;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/Makefile.in,v  <--  Makefile.in
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Async.html,v
done
Checking in mochikit/tests/MochiKit-Async.html;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Async.html,v  <--  MochiKit-Async.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Base.html,v
done
Checking in mochikit/tests/MochiKit-Base.html;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Base.html,v  <--  MochiKit-Base.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Color.html,v
done
Checking in mochikit/tests/MochiKit-Color.html;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Color.html,v  <--  MochiKit-Color.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-DOM.html,v
done
Checking in mochikit/tests/MochiKit-DOM.html;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-DOM.html,v  <--  MochiKit-DOM.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-DateTime.html,v
done
Checking in mochikit/tests/MochiKit-DateTime.html;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-DateTime.html,v  <--  MochiKit-DateTime.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-DragAndDrop.html,v
done
Checking in mochikit/tests/MochiKit-DragAndDrop.html;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-DragAndDrop.html,v  <--  MochiKit-DragAndDrop.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Format.html,v
done
Checking in mochikit/tests/MochiKit-Format.html;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Format.html,v  <--  MochiKit-Format.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Iter.html,v
done
Checking in mochikit/tests/MochiKit-Iter.html;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Iter.html,v  <--  MochiKit-Iter.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-JSAN.html,v
done
Checking in mochikit/tests/MochiKit-JSAN.html;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-JSAN.html,v  <--  MochiKit-JSAN.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Logging.html,v
done
Checking in mochikit/tests/MochiKit-Logging.html;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Logging.html,v  <--  MochiKit-Logging.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-MochiKit.html,v
done
Checking in mochikit/tests/MochiKit-MochiKit.html;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-MochiKit.html,v  <--  MochiKit-MochiKit.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Selector.html,v
done
Checking in mochikit/tests/MochiKit-Selector.html;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Selector.html,v  <--  MochiKit-Selector.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Signal.html,v
done
Checking in mochikit/tests/MochiKit-Signal.html;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Signal.html,v  <--  MochiKit-Signal.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Style.html,v
done
Checking in mochikit/tests/MochiKit-Style.html;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Style.html,v  <--  MochiKit-Style.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Visual.html,v
done
Checking in mochikit/tests/MochiKit-Visual.html;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/MochiKit-Visual.html,v  <--  MochiKit-Visual.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/cli.js,v
done
Checking in mochikit/tests/cli.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/cli.js,v  <--  cli.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/index.html,v
done
Checking in mochikit/tests/index.html;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/index.html,v  <--  index.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/standalone.js,v
done
Checking in mochikit/tests/standalone.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/standalone.js,v  <--  standalone.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_Base.js,v
done
Checking in mochikit/tests/test_Base.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_Base.js,v  <--  test_Base.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_Color.js,v
done
Checking in mochikit/tests/test_Color.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_Color.js,v  <--  test_Color.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_DateTime.js,v
done
Checking in mochikit/tests/test_DateTime.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_DateTime.js,v  <--  test_DateTime.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_DragAndDrop.js,v
done
Checking in mochikit/tests/test_DragAndDrop.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_DragAndDrop.js,v  <--  test_DragAndDrop.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_Format.js,v
done
Checking in mochikit/tests/test_Format.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_Format.js,v  <--  test_Format.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_Iter.js,v
done
Checking in mochikit/tests/test_Iter.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_Iter.js,v  <--  test_Iter.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_Logging.js,v
done
Checking in mochikit/tests/test_Logging.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_Logging.js,v  <--  test_Logging.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_MochiKit-Async.json,v
done
Checking in mochikit/tests/test_MochiKit-Async.json;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_MochiKit-Async.json,v  <--  test_MochiKit-Async.json
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_Signal.js,v
done
Checking in mochikit/tests/test_Signal.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/test_Signal.js,v  <--  test_Signal.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/SimpleTest/Makefile.in,v
done
Checking in mochikit/tests/SimpleTest/Makefile.in;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/SimpleTest/Makefile.in,v  <--  Makefile.in
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/SimpleTest/SimpleTest.js,v
done
Checking in mochikit/tests/SimpleTest/SimpleTest.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/SimpleTest/SimpleTest.js,v  <--  SimpleTest.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/SimpleTest/TestRunner.js,v
done
Checking in mochikit/tests/SimpleTest/TestRunner.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/SimpleTest/TestRunner.js,v  <--  TestRunner.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/SimpleTest/test.css,v
done
Checking in mochikit/tests/SimpleTest/test.css;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/SimpleTest/test.css,v  <--  test.css
initial revision: 1.1
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Commented ajax/Makefile.in pending further investigation into Linux error.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Test Suite Fix (obsolete) — — Splinter Review 
This is a new patch to fix the ailing MochiKit test suite, in Linux. The suite now runs against each test file individually, rather than the main test suite file (allowing it to move faster and be more responsive). Additionally, a path was fixed that was causing case-sensitivity issues. I tested this patch on a Linux system, and in OS X, and it ran perfectly in both.
Attachment #268251 - Flags: review?(rcampbell)
Comment on attachment 268251 [details] [diff] [review]
Test Suite Fix

you rock! would you mind regenerating the patch with cvs diff -u8p ? This is nonstandard.

I'll be able to check this in once the tree opens.
Attachment #268251 - Flags: review?(rcampbell) → review+
Attached patch Test Suite Fix — — Splinter Review 
New version of the patch, using cvs diff -u8p.
Attachment #268251 - Attachment is obsolete: true
checkin log

cvs commit: Examining .
cvs commit: Examining lib
cvs commit: Examining mochikit
cvs commit: Examining mochikit/MochiKit
cvs commit: Examining mochikit/tests
cvs commit: Examining mochikit/tests/SimpleTest
cvs commit: Examining offline
cvs commit: Examining prototype
cvs commit: Examining prototype/dist
cvs commit: Examining prototype/test
cvs commit: Examining prototype/test/lib
cvs commit: Examining prototype/test/unit
cvs commit: Examining prototype/test/unit/fixtures
Checking in Makefile.in;
/cvsroot/mozilla/dom/tests/mochitest/ajax/Makefile.in,v  <--  Makefile.in
new revision: 1.5; previous revision: 1.4
done
Checking in mochikit/manifest.json;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/manifest.json,v  <--  manifest.json
new revision: 1.2; previous revision: 1.1
done
Checking in mochikit/MochiKit/Makefile.in;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/MochiKit/Makefile.in,v  <--  Makefile.in
new revision: 1.2; previous revision: 1.1
done
Checking in mochikit/tests/SimpleTest/SimpleTest.js;
/cvsroot/mozilla/dom/tests/mochitest/ajax/mochikit/tests/SimpleTest/SimpleTest.js,v  <--  SimpleTest.js
new revision: 1.2; previous revision: 1.1
done
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Assignee: nobody → jresig
Component: Testing → DOM
QA Contact: testing → general
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: