379555 - Error recognizing the string "none" as a value for counter-increment and counter-reset property

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Daniel Holbert [:dholbert]]

When counter-increment is set manually to "none" and then read, it comes back as "none 1".  Similarly, when counter-reset is set to "none" and then read, it comes back as "none 0"

Was marked as a "todo" in the mochitest file layout/style/test/ test_value_computation.html.  Looking into this as my first bugfix -- dbaron says it's likely a parsing bug in nsCSSParser.cpp

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Proposed patch. (change LowerCaseEqualsLiteral to LowerCaseEqualsASCII)

This is my proposed fix.  After doing a GDB trace, I've found that the problem occurs because the compiler incorrectly tells LowerCaseEqualsLiteral that sv->str is a string-literal of length 13, even when it's shorter, because sv->str is a statically declared char-array with a length of 13.

(and i.e. for comparing "none" to "none", LowerCaseEqualsLiteral compares all 13 characters, going past the null terminus., and returns false when it should return true)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This looks good; it just also needs the diff for the mochitest to remove the expected failures -- and potentially equivalent changes for some other tests.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: Proposed patch #2 (removed todo's in mochi tests)

Same as previous patch, plus I removed TODO's in 2 mochitest files, for tests that this patch fixes.

Comment 4

[Daniel Holbert [:dholbert]]

Fix checked in to trunk by dbaron on my behalf.