When counter-increment is set manually to "none" and then read, it comes back as "none 1". Similarly, when counter-reset is set to "none" and then read, it comes back as "none 0" Was marked as a "todo" in the mochitest file layout/style/test/ test_value_computation.html. Looking into this as my first bugfix -- dbaron says it's likely a parsing bug in nsCSSParser.cpp
Created attachment 263623 [details] [diff] [review] Proposed patch. (change LowerCaseEqualsLiteral to LowerCaseEqualsASCII) This is my proposed fix. After doing a GDB trace, I've found that the problem occurs because the compiler incorrectly tells LowerCaseEqualsLiteral that sv->str is a string-literal of length 13, even when it's shorter, because sv->str is a statically declared char-array with a length of 13. (and i.e. for comparing "none" to "none", LowerCaseEqualsLiteral compares all 13 characters, going past the null terminus., and returns false when it should return true)
This looks good; it just also needs the diff for the mochitest to remove the expected failures -- and potentially equivalent changes for some other tests.
Created attachment 263675 [details] [diff] [review] Proposed patch #2 (removed todo's in mochi tests) Same as previous patch, plus I removed TODO's in 2 mochitest files, for tests that this patch fixes.
Fix checked in to trunk by dbaron on my behalf.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha5
You need to log in before you can comment on or make changes to this bug.