379654 - spacer doesn't handle many types of width/height values

Status: RESOLVED INVALID

(Core :: Layout: Block and Inline, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

nsSpacerFrame, used to implement HTML spacer elements, doesn't handle many types of values for CSS 'width' and 'height' properties, and also doesn't handle min-width and max-width.  See the XXX comments I'm adding to nsSpacerFrame as part of bug 311415.

(Not sure if spacer really needs its own frame class.  It could perhaps be block / inline-block depending on type.)

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

It also doesn't use the correct basis for percentage widths and heights.

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(And, in fact, for percentage heights, it does math on NS_UNCONSTRAINEDSIZE.)

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Though the simplest fix here is probably to just use mComputedWidth / mComputedHeight when applicable.

Comment 4

[(no longer active)]

(In reply to comment #3)
> Though the simplest fix here is probably to just use mComputedWidth /
> mComputedHeight when applicable.

Even simpler than that would be to remove the support for this element (bug 531030)!

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

spacer is dead.