379705 - Build movemail on Mac, just don't put it in the new account wizard in Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Joshua Root]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US) AppleWebKit/420+ (KHTML, like Gecko, Safari/420) OmniWeb/v607.17
Build Identifier: version 2.0.0.0 (20070326)

I have been using Thunderbird 1.5.10, and I have a single email account set up, which uses movemail. When I use Thunderbird 2.0, only "Local Folders" appears to exist. The movemail account is not in the Account Settings window, and its mail folders are not in the folders sidebar.

Reproducible: Always

Steps to Reproduce:
1. Make a movemail account with Thunderbird 1.5.x.
2. Use it for a while, send & receive some mail.
3. Start using Thunderbird 2.0.
Actual Results:  
Only Local Folders is present in folders sidebar and Account Settings window. Movemail account details and mail cannot be seen.

Expected Results:  
Movemail account and associated mail should be present.

Running Mac OS X version 10.4.9 on a Mac Pro.

Comment 1

[Stefan [:stefanh]]

This was removed in bug 365879. You should be able to set it up manually, though.

Comment 2

[Joshua Root]

Alrighty then. Summary changed. This isn't mentioned in the 2.0 release notes, and it doesn't seem very user-friendly to have the account simply stop working with no explanation. A warning that an RDF file needs to be installed would be handy.

Comment 3

[Magnus Melin [:mkmelin]]

Marking new.

Comment 4

[twm]

I'm experiencing the same problem.  However, copying "movemail.rdf" to the new Thunderbird 2.0 installation doesn't fix it.  I copied it to these locations:

/Applications/Thunderbird.app/Contents/MacOS/isp/
/Applications/Thunderbird.app/Contents/MacOS/isp/en-US/

This was in my attempt to upgrade from Thunderbird 1.5.0.12 to 2.0.0.0 on Mac OS X 10.4.9.  My movemail account shows up when I run Thunderbird 1.5, but not when I run 2.0, even with the RDF file copied.

Comment 5

[James McLean]

I can also confirm that Movemail does not work on MacOS X, even with the
movemail.rdf in "/Applications/Thunderbird.app/Contents/MacOS/isp" folder

Comment 6

[Phil Ringnalda (:philor)]

Well, since almost everyone's here already, I'll just morph this bug rather than file a new one.

Yeah, "oops." The intention in bug 365879 was to just remove movemail.rdf, so that it wouldn't show up as an account type in the new account wizard, but thanks to movemail's charming system of using MOZ_MOVEMAIL to define HAS_MOVEMAIL, then using that for code ifdefs, undefining MOZ_MOVEMAIL means that the whole backend doesn't get built.

Patch coming shortly, to just remove movemail.rdf from Thunderbird's .dmg, since Mnyromyr says he'd like to keep it in SeaMonkey's new account wizard.

Comment 7

[Phil Ringnalda (:philor)]

Attachment: Trunk fix v.1

Comment 8

[Phil Ringnalda (:philor)]

Attachment: Draft movemail.rdf extension

Could use a little polish (the homepage is particularly bad), but it's less trouble than stuffing movemail.rdf into the .app

Comment 9

[Benjamin Smedberg]

Comment on attachment 278523 [details] [diff] [review]
Trunk fix v.1

I don't like relying on packaging side-effects. It means, for instance, that if you run dist/Thunderbird.app you get different results than if you package it up and then run it, which isn't good for unit tests. Can you simply avoid building movemail.rdf in the first place on mac, here:

http://mxr.mozilla.org/mozilla/source/mailnews/base/ispdata/Makefile.in#50

Comment 10

[Phil Ringnalda (:philor)]

Attachment: Trunk fix v.2

Consensus seems to be that this is "horrid" rather than the "simply awful" that I thought it was, but if there's a way to be more cunning with the rock and stick that makefile syntax offers, it's escaping me.

Comment 11

[Benjamin Smedberg]

Comment on attachment 278733 [details] [diff] [review]
Trunk fix v.2

>Index: mailnews/base/ispdata/Makefile.in

>+ifeq (,$(filter cocoa,$(MOZ_WIDGET_TOOLKIT)))

this would be better written as

ifneq (cocoa,$(MOZ_WIDGET_TOOLKIT)

r=me with that change... this should be approved by a seamonkey peer if it hasn't been already.

Comment 12

[Karsten Düsterloh]

Comment on attachment 278733 [details] [diff] [review]
Trunk fix v.2

Whoo, I've never been this far out in autoconf/configure hell before... ;-)
r=me for SM.

Comment 13

[Phil Ringnalda (:philor)]

configure.in 1.1868
mailnews/base/ispdata/Makefile.in 1.18 (with the much less confusing ifneq cocoa, though I won't get to use that in the forthcoming branch patch)

Comment 14

[Phil Ringnalda (:philor)]

Attachment: Branch fix

Comment 15

[Phil Ringnalda (:philor)]

configure.in 1.1503.2.105
mailnews/base/ispdata/Makefile.in 1.8.28.7

QA: should you take leave of your senses and decide to verify this, there's three things to check:

* On Linux, you should see "Unix Mailspool (Movemail)" as a choice in the new account wizard

* On Mac, you should *not* see movemail as a new account type choice

* The hard part: on Mac, it should work, for which the easiest way (I know of) to check is use an existing mail profile to copy a single message into a folder, shut down, copy the mailbox (from aslkjdfs.default/Mail/Local Folders/Foo), rename it to your login name, and paste it into /var/mail/, then install the extension from attachment 278525 [details] and you should be able to create a movemail account, which will then tell you to change to excessively permissive permissions for /var/mail/, and when you do you should see that one message show up as new.