379727 - JavaMember should define trace/mark instead of using AddNamedRoot

Status: RESOLVED FIXED

(Core Graveyard :: Java: Live Connect, defect)

Description

[Igor Bukanov]

Currently js/src/liveconnect/jsj_JavaMember.c defines JavaMember JS class that use explicit AddNamedRoot/RemoveRoot API for managing its roots with RemoveRoot called from the finalizer.

Besides being eneficient, this can lead to leak when a JS object is stored inside Java entity. So the class should implement the standard trace/mark method instead.

Comment 1

[Igor Bukanov]

Attachment: fix v1

The patch implements the trace method to replace explicit root management.

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 263733 [details] [diff] [review]
fix v1

sr=me contingent upon r=alfred, since alfred is not an SR and is indeed the module owner.

/be

Comment 3

[Igor Bukanov]

Attachment: fix v2

In the previous patch I missed the fact that class prototype instance of JavaMember does not have private data so the trace must check for that. When I build a browser with liveconnect enabled, it exposed the problem instantly.

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 263920 [details] [diff] [review]
fix v2

Oops, I should have seen that one coming...

/be

Comment 5

[Alfred Peng]

Comment on attachment 263920 [details] [diff] [review]
fix v2

Looks fine for me. Thanks for the patch. r=alfred.

Comment 6

[Igor Bukanov]

I committed the patch from comment 3 to the trunk:

Checking in liveconnect/jsj_JavaMember.c;                                                                                                                          
/cvsroot/mozilla/js/src/liveconnect/jsj_JavaMember.c,v  <--  jsj_JavaMember.c                                                                                      
new revision: 1.18; previous revision: 1.17                                                                                                                        
done