379770 - Exception in nsLivemarkService.js causes broken live bookmarks

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Ronny Perinke]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.4pre) Gecko/20070504 Firefox/2.0.0.4pre (Sephiroth/SSE2)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070504 Minefield/3.0a5pre

If you try to open a bookmarks folder that contains a live bookmark, you receive error messages in the error console and no live bookmark will be loaded.

Reproducible: Always

Steps to Reproduce:
1. open the bookmarks menu and navigate to a folder where which contains a live bookmark
Actual Results:  
live bookmarks don't load; clicking on it give's an error message saying:
"The URL is not valid and cannot be loaded."

+ the error messages below

Expected Results:  
working live bookmarks ;-)

Error: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIAnnotationService.getAnnotationString]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: file:///D:/Mozilla%20Stuff/firefox-3.0a5pre.en-US.win32.places/firefox/components/nsLivemarkService.js :: LivemarkService :: line 757"  data: no]
Source File: file:///D:/Mozilla%20Stuff/firefox-3.0a5pre.en-US.win32.places/firefox/components/nsLivemarkService.js
Line: 757


Error: uncaught exception: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: chrome://browser/content/places/utils.js :: anonymous :: line 112"  data: no]

Comment 1

[Ronny Perinke]

works
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/20070422 Minefield/3.0a4pre
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/experimental/places/2007-04-22-04-trunk/

fails
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/20070423 Minefield/3.0a4pre
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/experimental/places/2007-04-23-04-trunk/


I guess it's either caused by bug #377066 or bug #376851

Comment 2

[(not reading, please use [e-mail] instead)]

confirming, I think i've seen this, or at least that error in my console before.

But as of right now, I can't reproduce it.

I'm using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070503 Minefield/3.0a5pre

ronny, can you specify why rss feed you are using?

Comment 3

[tabmix.onemen]

try new profile maybe your places.sqlite is busted 

Comment 4

[Ronny Perinke]

(In reply to comment #3)
> try new profile maybe your places.sqlite is busted 
> 
that's it. everything (related to rss) works fine with a new profile.

(In reply to comment #2)
> confirming, I think i've seen this, or at least that error in my console
> before.
> 
> But as of right now, I can't reproduce it.
> 
> I'm using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre)
> Gecko/20070503 Minefield/3.0a5pre
> 
> ronny, can you specify why rss feed you are using?
> 

It's one of flickr. It happend also if I did a right click on the feed and the properties dialog had no content, only a window frame with the close button.

Comment 5

[Ronny Perinke]

I compared the places.sqlite of 22/04/2007 build with the one from 23/04/2007.

The really interesting part is her in the moz_annos (livemarks) table.

22/04
CREATE TABLE moz_annos (id INTEGER PRIMARY KEY,place_id INTEGER NOT NULL,anno_attribute_id INTEGER,mime_type VARCHAR(32) DEFAULT NULL,content LONGVARCHAR, flags INTEGER DEFAULT 0,expiration INTEGER DEFAULT 0);
INSERT INTO "moz_annos" VALUES(1,3,1,NULL,'http://en-us.fxfeeds.mozilla.com/en-US/firefox/headlines.xml',0,4);
INSERT INTO "moz_annos" VALUES(2,3,2,NULL,'http://en-us.fxfeeds.mozilla.com/en-US/firefox/livebookmarks/',0,4);

23/04
CREATE TABLE moz_annos (id INTEGER PRIMARY KEY,place_id INTEGER NOT NULL,anno_attribute_id INTEGER,mime_type VARCHAR(32) DEFAULT NULL,content LONGVARCHAR, flags INTEGER DEFAULT 0,expiration INTEGER DEFAULT 0, type INTEGER DEFAULT 0);
INSERT INTO "moz_annos" VALUES(1,3,1,NULL,'http://en-us.fxfeeds.mozilla.com/en-US/firefox/headlines.xml',0,4,3);
INSERT INTO "moz_annos" VALUES(2,3,2,NULL,'http://en-us.fxfeeds.mozilla.com/en-US/firefox/livebookmarks/',0,4,3);



There is a new type attribute, which will be 0 in old places.sqlite files that are used with newer builds, resulting in broken livemarks.

Comment 6

[Dietrich Ayala (:dietrich)]

per comment #5, this appears to be a migration issue between early alphas. there have been no further reports of this in over a year -> WFM.

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv