379813 - Multiple versions with same version number can be created

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Andrei [:sancus]]

Steps to Reproduce:

1) Click "New Version" in the dev cp and upload an XPI set to a platform, f ex: "Windows", follow the prompts and upload the file.

2) Click "New Version" again, and upload the same XPI set to a different platform, f ex: "Linux".

There are two versions with different version ids, each having one file if you do this.

One would expect that the second upload would fail, stating that there's already an existing version with that version number.

Comment 2

[Justin Scott [:fligtar]]

Fixed in 3.5.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; I just got another version, as I'd expect.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #3)
> Verified FIXED; I just got another version, as I'd expect.

Actually, wait; I got "Could not move file" -- is that an expected error message?

Comment 5

[Justin Scott [:fligtar]]

(In reply to comment #4)
> (In reply to comment #3)
> > Verified FIXED; I just got another version, as I'd expect.
> 
> Actually, wait; I got "Could not move file" -- is that an expected error
> message?

No. Filed bug 453700.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of what I see with the steps from comment 0

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

I have no idea what I was reporting on in comment 3, but what I see on https://remora-3.5.php5stage.mozilla.com/en-US/developers/versions/edit/46596 seems to correct: each platform gets assigned to the same version.

Fligtar: that's the right behavior, yes?

Comment 8

[Justin Scott [:fligtar]]

Yes. Each file with the same version number should be under one version.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Yah.  Verified fixed.