379822 - Encoding autodetect language setting does not work in message source window in Thunderbird

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Seiji Kaneko]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1.2pre) Gecko/20070223 Camino/1.1b
Build Identifier: 2.0.0.0(20070326)

In message source window, there is a encoding setting menu for the mail text. It also has autodetect feature, and has submenu for language setting for autodetection. This submenu doesn't work, for it doesn't remember the setting and turn back to default (Traditional chinese).

Reproducible: Always

Steps to Reproduce:
1. Open message source for a mail.
2. set autodetect language setting from submenu of "View".
3.



Explicit encode setting works. It is language setting only bug.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Fix

Hi, it's me, the one with the lame app that tries to do view source without having history enabled. Can I have a few more uses of isHistoryEnabled()?

Comment 2

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/d4496c7ecff5

Comment 3

[Phil Ringnalda (:philor)]

Comment on attachment 375499 [details] [diff] [review]
Fix

Drivers: the only difference for Firefox is that changing character encoding in view source will take an extra millisecond, from calling a function that always returns true for Fx before running the exact same code as before. For Thunderbird, it's the difference between having charset changes in view source work, and do absolutely nothing.

Comment 4

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/066302cfde43