Removing JS_GetGCMarkingTracer

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Igor Bukanov, Assigned: Igor Bukanov)

Tracking

(Blocks: 1 bug)

unspecified
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
I added JS_GetGCMarkingTracer to allow to access the marking tracer from GC callback. But with introduction of JS_SetExtraGCRoots, bug 379146, this is not necessary. I.e. one either continues to use the old JS_MarkGCThing and does not worry about the tracing. Or one switches to the tracing API and stop abusing JSGC_MARK_END like xpconnect currently does, bug 340212.

Thus after landing bug 340212 the API could be and, in fact, should be removed.
(Assignee)

Updated

11 years ago
Blocks: 378742
Depends on: 340212
(Assignee)

Comment 1

11 years ago
Created attachment 264857 [details] [diff] [review]
Implementation v1

Straightforward code removal
Attachment #264857 - Flags: review?(brendan)

Updated

11 years ago
Attachment #264857 - Flags: review?(brendan) → review+
(Assignee)

Comment 2

11 years ago
I committed the patch from comment 1 to the trunk:

Checking in jsapi.c;
/cvsroot/mozilla/js/src/jsapi.c,v  <--  jsapi.c
new revision: 3.321; previous revision: 3.320
done
Checking in jsapi.h;
/cvsroot/mozilla/js/src/jsapi.h,v  <--  jsapi.h
new revision: 3.151; previous revision: 3.150
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.