Closed
Bug 379885
Opened 19 years ago
Closed 19 years ago
Removing JS_GetGCMarkingTracer
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: igor, Assigned: igor)
References
Details
Attachments
(1 file)
|
1.72 KB,
patch
|
brendan
:
review+
|
Details | Diff | Splinter Review |
I added JS_GetGCMarkingTracer to allow to access the marking tracer from GC callback. But with introduction of JS_SetExtraGCRoots, bug 379146, this is not necessary. I.e. one either continues to use the old JS_MarkGCThing and does not worry about the tracing. Or one switches to the tracing API and stop abusing JSGC_MARK_END like xpconnect currently does, bug 340212.
Thus after landing bug 340212 the API could be and, in fact, should be removed.
|
Assignee | |
Updated•19 years ago
|
|
|
Assignee | |
Comment 1•19 years ago
|
||
Straightforward code removal
Attachment #264857 -
Flags: review?(brendan)
|
|
||
Updated•19 years ago
|
Attachment #264857 -
Flags: review?(brendan) → review+
|
|
Assignee | |
Comment 2•19 years ago
|
||
I committed the patch from comment 1 to the trunk:
Checking in jsapi.c;
/cvsroot/mozilla/js/src/jsapi.c,v <-- jsapi.c
new revision: 3.321; previous revision: 3.320
done
Checking in jsapi.h;
/cvsroot/mozilla/js/src/jsapi.h,v <-- jsapi.h
new revision: 3.151; previous revision: 3.150
done
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•19 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•