Closed Bug 379889 Opened 17 years ago Closed 17 years ago

nsProgressDialog.js uses formatStringByName inappropriately

Categories

(Core Graveyard :: File Handling, defect)

Product:
Core Graveyard
Component:
File Handling
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file, 2 obsolete files)

Fix typo in typo fix
1.32 KB, patch
Biesinger
: superreview+
Details | Diff | Splinter Review 
The "DontAskAgain" string has no format parameters but nsProgressDialog's onLaunch method tries to format it anyway. See bug 269893 and bug 268832.
Attached patch Proposed patch (obsolete) — — Splinter Review 

        Attachment #263940 -
        Flags: superreview?(cbiesinger)

        Attachment #263940 -
        Flags: review?(smontagu)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fix typo (obsolete)
        — 
          — Splinter Review
      

    


  
Sorry, I obviously thought this was a no-brainer, so I used no brain :-[
Assignee: file-handling → neil

        Attachment #263940 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

        Attachment #263944 -
        Flags: superreview?(cbiesinger)

        Attachment #263944 -
        Flags: review?(smontagu)

        Attachment #263940 -
        Flags: superreview?(cbiesinger)

        Attachment #263940 -
        Flags: review?(smontagu)

    
    

    
  
Comment on attachment 263944 [details] [diff] [review]
Fix typo

I strongly prefer |foo ? bar : baz| to |!foo ? baz : bar|

        Attachment #263944 -
        Flags: review?(smontagu) → review+

    
    

    
  


  
Sigh. This was the entire reason I didn't copy & paste in the first place.

I also switched the cases around as per smontagu's review comment.

Third time lucky!

        Attachment #263944 -
        Attachment is obsolete: true

        Attachment #263991 -
        Flags: superreview?(cbiesinger)

        Attachment #263944 -
        Flags: superreview?(cbiesinger)

        Attachment #263991 -
        Flags: superreview?(cbiesinger) → superreview+

    
    

    
  
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: