Closed Bug 380022 Opened 14 years ago Closed 14 years ago

implement IAccessibleImage

Categories

(Core :: Disability Access APIs, defect)

All
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
No description provided.
Attachment #264089 - Flags: review?(aaronleventhal)
Comment on attachment 264089 [details] [diff] [review]
patch

#define CANT_QUERY_ACCESSIBLEIMAGE_ASSERTION_MSG \
"Subclass of CAccessibleImage doesn't implement nsIAccessibleImage"\
I'd prefer static const char* kMessageName, but if you decide to do this you don't need a \ on the last line. If someone ever deletes the next blank line it would cause problems.

I wonder if Image::description should be a longdesc -- although we'd have to get those asynchronously. For now we can keep it as name and file a follow up bug to investigate that.

You have a couple of |return NS_OK| where it should be |S_OK|
Attachment #264089 - Flags: review?(aaronleventhal) → review+
Assignee: aaronleventhal → surkov.alexander
Attached patch patch2Splinter Review
to checkin
Attachment #264089 - Attachment is obsolete: true
(In reply to comment #2)
> Created an attachment (id=264222) [details]
> patch2
> 
> to checkin
> 

checked in
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
(In reply to comment #1)

> I wonder if Image::description should be a longdesc -- although we'd have to
> get those asynchronously. For now we can keep it as name and file a follow up
> bug to investigate that.

What is longdesc? Is it more detailed description that GetName() returns?
A longdesc is an attribute on an image that points to an URL with a long description of the image. It can have tables, even form controls, etc. because it can be a full web page.

Here's a testcase: http://www.hixie.ch/tests/evil/mixed/IMGlongdesc.html
It's an old issue! (Bug 1996), so don't worry about it now.

We might want to expose an extra action at some point, when longdesc is available, to open the long description in a new tab. Right now you have to right click on the image, get properties, copy the URL, start a new tab, and paste in the URL.


So, forget I brought it up :)
You need to log in before you can comment on or make changes to this bug.