Closed Bug 380096 Opened 17 years ago Closed 17 years ago

[FIX]"ASSERTION: Should have found a parent before this" with inline-table root, table-caption, and float

Categories

(Core :: Layout: Tables, defect, P2)

Product:
Core
Component:
Layout: Tables
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha6

People

(Reporter: jruderman, Assigned: bzbarsky)

References

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

testcase
152 bytes, text/html
Details
Nothing like touching up the paint on a sinking ship
6.77 KB, patch
bernd_mozilla
: review+
roc
: superreview+
Details | Diff | Splinter Review
Attached file testcase — 
###!!! ASSERTION: Should have found a parent before this: 'aProspectiveParent->GetStyleContext()->GetPseudoType() == nsCSSAnonBoxes::viewportScroll', file /Users/jruderman/trunk/mozilla/layout/generic/nsFrame.cpp, line 5517

I don't know whether this can lead to a crash like bug 379386 did.
More IsValidSibling() fun... This is in fact resolving a style context against the wrong parent frame.  We shouldn't be doing that...
Component: Layout → Layout: Tables
QA Contact: layout → layout.tables

        Attachment #264216 -
        Flags: superreview?(roc)

        Attachment #264216 -
        Flags: review?(bernd_mozilla)

    
    

    
  
Not sure how testable this is...
Flags: in-testsuite?
OS: Mac OS X → All
Priority: -- → P2
Hardware: PC → All
Summary: "ASSERTION: Should have found a parent before this" with inline-table root, table-caption, and float → [FIX]"ASSERTION: Should have found a parent before this" with inline-table root, table-caption, and float
Target Milestone: --- → mozilla1.9alpha6

    
    

    
  
Comment on attachment 264216 [details] [diff] [review]
Nothing like touching up the paint on a sinking ship

yeah, but this ships sinks so slowly that one is always tempted to turn on the pump again to keep it floating.

        Attachment #264216 -
        Flags: review?(bernd_mozilla) → review+

        Attachment #264216 -
        Flags: superreview?(roc) → superreview+

    
    

    
  
Checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
    

    
  
Crashtest checked in.
Flags: in-testsuite? → in-testsuite+

    
  
Assignee: nobody → bzbarsky

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: