[FIX]"ASSERTION: Should have found a parent before this" with inline-table root, table-caption, and float

RESOLVED FIXED in mozilla1.9alpha6

Status

()

P2
normal
RESOLVED FIXED
12 years ago
8 years ago

People

(Reporter: jruderman, Assigned: bzbarsky)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla1.9alpha6
assertion, testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
Created attachment 264170 [details]
testcase

###!!! ASSERTION: Should have found a parent before this: 'aProspectiveParent->GetStyleContext()->GetPseudoType() == nsCSSAnonBoxes::viewportScroll', file /Users/jruderman/trunk/mozilla/layout/generic/nsFrame.cpp, line 5517

I don't know whether this can lead to a crash like bug 379386 did.
(Assignee)

Comment 1

12 years ago
More IsValidSibling() fun... This is in fact resolving a style context against the wrong parent frame.  We shouldn't be doing that...
Component: Layout → Layout: Tables
QA Contact: layout → layout.tables
(Assignee)

Comment 2

12 years ago
Created attachment 264216 [details] [diff] [review]
Nothing like touching up the paint on a sinking ship
Attachment #264216 - Flags: superreview?(roc)
Attachment #264216 - Flags: review?(bernd_mozilla)
(Assignee)

Comment 3

12 years ago
Not sure how testable this is...
Flags: in-testsuite?
OS: Mac OS X → All
Priority: -- → P2
Hardware: PC → All
Summary: "ASSERTION: Should have found a parent before this" with inline-table root, table-caption, and float → [FIX]"ASSERTION: Should have found a parent before this" with inline-table root, table-caption, and float
Target Milestone: --- → mozilla1.9alpha6

Comment 4

12 years ago
Comment on attachment 264216 [details] [diff] [review]
Nothing like touching up the paint on a sinking ship

yeah, but this ships sinks so slowly that one is always tempted to turn on the pump again to keep it floating.
Attachment #264216 - Flags: review?(bernd_mozilla) → review+
Attachment #264216 - Flags: superreview?(roc) → superreview+
(Assignee)

Comment 5

12 years ago
Checked in.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

11 years ago
Crashtest checked in.
Flags: in-testsuite? → in-testsuite+

Updated

8 years ago
Assignee: nobody → bzbarsky
You need to log in before you can comment on or make changes to this bug.