Closed Bug 380125 Opened 17 years ago Closed 17 years ago

nsIFeedResult.idl contains reserved C++ keyword "namespace"

Categories

(Toolkit Graveyard :: XULRunner, defect)

Product:
Toolkit Graveyard
Component:
XULRunner
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: tom.germeau, Assigned: tom.germeau)

Details

Attachments

(1 file, 1 obsolete file)

a-prefixing both parameters
559 bytes, patch
Gavin
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; nl; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: 

When including this autogenerated nsIFeedResult.h you'll get a compile error on the first parameter "namespace" from RegisterExtensionPrefix.



Reproducible: Always

        Attachment #264219 -
        Flags: review+
Status: UNCONFIRMED → NEW
Ever confirmed: true

        Attachment #264219 -
        Flags: review+ → review?
OS: Windows XP → All
OS: All → Windows XP
Assignee: nobody → tom.germeau
OS: Windows XP → All
Hardware: PC → All

    
  

        Attachment #264219 -
        Flags: review? → review?(bugs)

    
    

    
  
Comment on attachment 264219 [details] [diff] [review]
Mini patch changing the name of the parameter

Ben's not actively reviewing Firefox patches (see http://www.mozilla.org/projects/firefox/review.html for a list of active reviewers). If you're going to change the first parameter to be a-prefixed, you might as well be consistent and change the second too.

        Attachment #264219 -
        Flags: review?(bugs)

    
    

    
  


  

        Attachment #264219 -
        Attachment is obsolete: true

        Attachment #264754 -
        Flags: review?(gavin.sharp)

        Attachment #264754 -
        Flags: review?(gavin.sharp) → review+

    
    

    
  
Checking in nsIFeedResult.idl;
/cvsroot/mozilla/toolkit/components/feeds/public/nsIFeedResult.idl,v  <--  nsIFeedResult.idl
new revision: 1.4; previous revision: 1.3

Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
  
Flags: in-testsuite-
Product: Toolkit → Toolkit Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: