380170 - wrong Platform on Intel Mac

Status: RESOLVED INVALID

(Bugzilla :: Bugzilla-General, defect)

Description

[Frank Becker]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; de-de) AppleWebKit/419 (KHTML, like Gecko) Safari/419.3
Build Identifier: bugzilla3.0rc1

in enter_bug.cgi Platform get set to PC.

To fix this move line 225 
            /\(.*Macintosh.*\)/ && do {@platform = "Macintosh"; last;};
before line 202
        #Intel x86
            /\(.*Intel.*\)/ && do {@platform = "PC"; last;};   <=== insert before this line




Reproducible: Always

Steps to Reproduce:
1. enter a new bug
2.
3.
Actual Results:  
Platform:	PC

Expected Results:  
Platform: Macintosh

Comment 1

[Frédéric Buclin]

timeless, can you look at this?

Comment 2

[Frank Becker]

I found a better solution for this.

the HTTP_USER_AGENT is for Firefox
      Mozilla/5.0 (Macintosh; U; Intel Mac OS X; de; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
anf for Safari
      Mozilla/5.0 (Macintosh; U; Intel Mac OS X; de-de) AppleWebKit/419 (KHTML, like Gecko) Safari/419.3

so when wee look for Intel Mac OS X we say that the Platform is Macintosh.
We need to add a test for String "Intel Mac OS X" in HTTP_USER_AGENT before we do the test for "Intel"

Change file enter_bug.cgi in sub pickplatform.

old lines
        #Intel x86
            /\(.*Intel.*\)/ && do {@platform = "PC"; last;};

new lines
        #Intel x86
        # beginn insert to test for Intel Mac's
            /\(.*Intel Mac OS X.*\)/ && do {@platform = "Macintosh"; last;};
       # end insert to test for Intel Mac's
            /\(.*Intel.*\)/ && do {@platform = "PC"; last;};

Comment 3

[Teemu Mannermaa (:wicked)]

I was under the impression that we selected PC on purpose for these systems. Their hardware really is Intel which is PC and the old Mac hardware is a different beast. So IMO the most logical choice is already selected. However, I don't do macs and timely owns this logic so he should decide what we call them.

Comment 4

[Frank Becker]

(In reply to comment #3)
> I was under the impression that we selected PC on purpose for these systems.
> Their hardware really is Intel which is PC and the old Mac hardware is a
> different beast. So IMO the most logical choice is already selected. However, I
> don't do macs and timely owns this logic so he should decide what we call them.
> 

I think most Mac owner think a Intel Macintosh is a Macintosh and not a PC. Maybe it is better to define the new Platform "Intel Macintosh"  to make clear that this is not an old Power Macintosh. and not a PC.

rep_platform is described as: This is the hardware platform against which the bug was reported. 

The processor is only a part of the platform.

Maybe change platform to processor and change PC to Intel, Macintosh to Power or old 68k, ...

Comment 5

[timeless]

I'd rather wontfix this. the right fix is to rename the fields, they're hardware architecture bound with bad user facing labels.

what matters to the user is that the OS properly gets Mac OS X.

in my book, this bug is invalid because the code is working as designed.

frank: what are you guys doing that gives you a win by having two ways to search for Macintosh (hardware, os)?

Comment 6

[Frank Becker]

(In reply to comment #5) 
> frank: what are you guys doing that gives you a win by having two ways to
> search for Macintosh (hardware, os)?
>
Hardware Macintosh is for OS versions (Mac System 8.0, Mac System 8.1, Mac System 8.5, Mac System 8.6, Mac System 9.0, Mac System 9.x, Mac OS X, Mac OS X 10.0,Mac OS X 10.3,Mac OS X 10.4). So what is the div to PC with OS version (Windows NT,Windows 3.1, Windows 95, Windows 98, Windows ME, Windows 2000, Windows Server 2003, Windows Server XPWindows Vista)?

For me it is important to know the enviroment when i have to fix a bug. So I need to know if this was on an PPC MacOS or an Intel MacOS.

But if you have an browser problem you need the know the browser version to. What about to save the whole HTTP_USER_AGENT andshow this only on demand.