380173 - Rhino E4X: Problem with automatic property expansion

Status: RESOLVED DUPLICATE of bug 524931

(Rhino Graveyard :: E4X, defect)

Description

[David Caldwell]

var html = <html/>;
html.head.title = "My Page Title";
html.body.@bgcolor = "#e4e4e4";
html.body.form.@name = "myform";
html.body.form.@action = "someurl.jss";
html.body.form.@method = "post";
html.body.form.@onclick = "return somejs();";
html.body.form.input[0] = "";
html.body.form.input[0].@name = "test";

... yields:

java.lang.NullPointerException
        at org.mozilla.javascript.xmlimpl.XMLList.put(XMLList.java:227)
        at org.mozilla.javascript.xmlimpl.XMLObjectImpl.ecmaPut(XMLObjectImpl.java:288)
        at org.mozilla.javascript.ScriptRuntime.setObjectIndex(ScriptRuntime.java:1498)
        at org.mozilla.javascript.ScriptRuntime.setObjectIndex(ScriptRuntime.java:1486)
        at org.mozilla.javascript.Interpreter.interpretLoop(Interpreter.java:2951)
        at org.mozilla.javascript.Interpreter.interpret(Interpreter.java:2326)
        at org.mozilla.javascript.InterpretedFunction.call(InterpretedFunction.java:162)
        at org.mozilla.javascript.ContextFactory.doTopCall(ContextFactory.java:387)
        at org.mozilla.javascript.ScriptRuntime.doTopCall(ScriptRuntime.java:2818)
        at org.mozilla.javascript.InterpretedFunction.exec(InterpretedFunction.java:173)
        at inonit.script.rhino.Engine$Program$SourceUnit.execute(Engine.java:693)
        at inonit.script.rhino.Engine$Program.execute(Engine.java:574)
        at inonit.script.rhino.Engine$Program.interpret(Engine.java:602)
        at inonit.script.rhino.Engine$ProgramAction.run(Engine.java:729)
        at org.mozilla.javascript.Context.call(Context.java:559)
        at org.mozilla.javascript.ContextFactory.call(ContextFactory.java:497)
        at inonit.script.rhino.Engine.execute(Engine.java:366)
        at inonit.script.jsh.ScriptHost.execute(ScriptHost.java:138)
        at inonit.script.jsh.Main.run(Main.java:204)
        at inonit.script.jsh.Main.main(Main.java:236)

Reported via E-mail.  I will investigate.

Comment 1

[Hannes Wallnoefer]

Attachment: Implement property expansion for array-like access

This seems to fix the problem. I haven't really tried to understand what goes on farther down that method, and I suspect that it might be ok to return immediately after creating the expanded element. Probably David should have another look.

Bug 394215 and bug 415950 are duplicates of this.

Comment 2

[David Caldwell]

Realistically I'm unavailable until after Election Day in America (Nov. 4) as I have moved to Florida and taken a sabbatical from IT to work in a campaign capacity.  Use this information in whatever way you see fit. :)

Comment 3

[Hannes Wallnoefer]

Attachment: Revised patch

Use ScriptRuntime.toString(value) instead of value.toString()

Comment 4

[Hannes Wallnoefer]

Attachment: Test script

Test script for E4X property expansion. Now produces same result as spidermonkey except for the display of empty elements.

Comment 8

[Hannes Wallnoefer]

Fixed - see bug #524931

Comment 9

[Hannes Wallnoefer]

Marking as duplicate of bug #524931