380362 - special "Get Bookmark Add-ons" favicon is overriden by the mozilla site favicon after you load it once

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect, P4)

Description

[(not reading, please use [e-mail] instead)]

special "Get Bookmark Add-ons" favicon is overriden by the mozilla site favicon after you load it once.

I believe the desired favicon comes from this filemozilla/browser/locales/en-US/profile/bookmarks.html

I think this fx-2 parity issue is a result of the favicon service that we use in places bookmarks.  

normally, we want this functionality, so we may need some css to force the favicon for this bookmark to stay "special".  

(I guess we could set the favicon on the server side, too)

let me attach a screen shot.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot of the special "Get Bookmark Add-ons" menu item under the Bookmarks menu (before and after I click on it)

Comment 2

[(not reading, please use [e-mail] instead)]

speaking like a client guy, it would be great to fix this on the server side.

http://lxr.mozilla.org/mozilla/source/browser/locales/en-US/profile/bookmarks.html

Our link will be:

https://en-us.add-ons.mozilla.com/en-US/firefox/bookmarks/

but that currently redirects to:

https://addons.mozilla.org/en-US/firefox/browse/type:1/cat:22/sort:popular

We might have a bug about favicon's and redirects (#389642), but I don't know yet how we'll deal with that.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Server-side fix is the way to go - what's the best way to track this as a blocker but file against AMO? Create a dependent bug?

Also, I think we'll want to remove this from the default profile for Firefox 3, and instead add a button on the Places Organizer that gets bookmarks related Add-ons.

Comment 4

[Dave Townsend [:mossop]]

(In reply to comment #3)
> Also, I think we'll want to remove this from the default profile for Firefox 3,
> and instead add a button on the Places Organizer that gets bookmarks related
> Add-ons.

Sounds like bug 389391. But if you're removing the bookmark this becomes a non-bug and do you even need to change the favicon on the server?

Comment 5

[Mike Connor [:mconnor]]

Either we should drop this from the default Fx3 profile or fix on the server side.  Assigning to beltzner to determine which is appropriate.

Comment 6

[Mike Connor [:mconnor]]

Not going to continue to block on this.  If you disagree with this decision, please renominate with reasons why we can't ship with this in final

Comment 7

[fredkrue]

I remember this same issue for Firefox 3.0 and it was fixed, and not the same thing is happening with v3.5 and will not get fixed? :S

Comment 8

[fredkrue]

Sorry I meant to say ..and "now" the same thing is happening with v3.5...

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 10

[Marco Bonardo [:mak]]

this entry has been removed in bug 515435.