380421 - get crash reporter params from nsXULAppInfo

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[(not currently active) Ted Mielczarek]

We should be parsing parameters from application.ini instead of crashreporter.ini.  We need to get them out of there to allow l10n on that file.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: get enabled and server url from nsXULAppInfo

This patch adds a crashReporterURL to nsXULAppInfo, and also adds a flag, NS_XRE_ENABLE_CRASH_REPORTER.  They are settable in application.ini like so:
[Crash Reporter]
Enabled=1
ServerURL=http://example.com/submit

The ServerURL gets passed to the crash reporter client via the extra data API.  This patch tweaks Firefox's appData settings to have the right server URL, but not to enable crash reporting by default.  I kept the MOZ_AIRBAG=1 env var hack for now so we can continue to test Firefox.

The patch also cleans up a few warnings from the crash reporter client code.

Comment 2

[Benjamin Smedberg]

Comment on attachment 264994 [details] [diff] [review]
get enabled and server url from nsXULAppInfo

Please add an envvar check to override the submission URL, and make equivalent nsXULAppInfo changes for Thunderbird.

Comment 3

[(not currently active) Ted Mielczarek]

Checked in.  Need to figure out some tests for this.