380449 - potential data loss on export of LAST_MODIFIED, DATE_ADDED and ICON_URI attributes (nsPlacesImportExportService.cpp)

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

potential data loss on export of folderIds, itemIds, and favicon specs (nsPlacesImportExportService.cpp)

this will also be a concern once import/export of date added and last modified are implemented (see bug #371827)

the external api (nsStringAPI.h) does not have a 64-bit appendint

I think we need to use the internal string api.

from my windows build:

nsPlacesImportExportService.cpp
c:/builds/trunk-no-places/mozilla/browser/components/places/src/nsPlacesImportEx
portService.cpp(1095) : warning C4244: 'argument' : conversion from 'PRTime' to
'int', possible loss of data
c:/builds/trunk-no-places/mozilla/browser/components/places/src/nsPlacesImportEx
portService.cpp(1434) : warning C4244: 'argument' : conversion from 'PRInt64' to
 'int', possible loss of data
c:/builds/trunk-no-places/mozilla/browser/components/places/src/nsPlacesImportEx
portService.cpp(1574) : warning C4244: 'argument' : conversion from 'PRInt64' to
 'int', possible loss of data
c:/builds/trunk-no-places/mozilla/browser/components/places/src/nsPlacesImportEx
portService.cpp(1693) : warning C4244: 'argument' : conversion from 'PRInt64' to
 'int', possible loss of data

Comment 1

[(not reading, please use [e-mail] instead)]

for a real world instance of this problem, see bookmarks.html:

ICON_URI="http://www.mozilla.org/2005/made-up-favicon/0--547403822

the code that is generating that is:

    // make up favicon URL
    nsCAutoString faviconSpec;
    faviconSpec.AssignLiteral("http://www.mozilla.org/2005/made-up-favicon/");
    faviconSpec.AppendInt(serialNumber);
    faviconSpec.AppendLiteral("-");
    faviconSpec.AppendInt(PR_Now()); // casting from PRInt64 -> PRInt32, data loss, fix me

Comment 2

[(not reading, please use [e-mail] instead)]

we are going to stop exporting item ids and folder ids to bookmarks.html (see bug #383840), but we will still have the problem with favicon icon specs

Comment 3

[(not reading, please use [e-mail] instead)]

accepting, I have a fix for this in bug #383840

Comment 4

[(not reading, please use [e-mail] instead)]

updating summary

Comment 5

[(not reading, please use [e-mail] instead)]

fixed with the fix for bug #383840

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv