380461 - crash on imap login

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Tuukka Tolvanen (sp3000)]

Attachment: bt

trunk tbird linux
2007-05-10 08:00 PDT ok
2007-05-10 09:00 PDT crash, albeit a different stack at that time ;)

Comment 1

[Tuukka Tolvanen (sp3000)]

#8  0xb6c35ef3 in nsDependentCString (this=0xb18c6ea0, data=0x0)
    at ../../../../dist/include/string/nsTDependentString.h:89
No locals.
#9  0xb6e9bb08 in nsImapProtocol::ProcessAfterAuthenticated (this=0x91ce7b8)
    at /home/tt/src/moz/trunk/mozilla/mailnews/imap/src/nsImapProtocol.cpp:7314
	hasAdminUrl = 0

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mailnews/imap/src/nsImapProtocol.cpp&rev=1.653&mark=7312-7314#7298

Comment 2

[Scott MacGregor]

Hmm, I wonder if we get a null string back from GetManageListsUrl, GetManageFiltersUrl or GetMailAccountUrl. Either way this should be fix. I'll take a look this morning.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Same happens for Mac OS X. See bug 380585 or attachment 264686 [details] for a stack trace.

Comment 5

[Scott MacGregor]

Attachment: possible fix

I'm not entirely convinced this patch will fix the crash but it can't hurt. We may also need to protect against CreateNilString and CreateAString returning NULL.

Comment 6

[David :Bienvenu]

Comment on attachment 264749 [details] [diff] [review]
possible fix

yes, I've seen and fixed crashes for a similar reason (not in this code, though).

Comment 7

[Scott MacGregor]

Tuukka, I've checked this in, can you update you tree in mailnews\imap and tell me if this fixes the problem for you? Thanks!

Comment 8

[Tuukka Tolvanen (sp3000)]

yeah, not crashing now :)

Comment 9

[Scott MacGregor]

cool. marking fixed.