380505 - Simplify and optimize mDBGetChildren

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

Now that items of all types live in the same table (moz_bookmarks), we can get rid of the multiple selective statements which build mDBGetChildren. This should help performance a lot when getting the children of a large bookmarks folder.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 264600 [details] [diff] [review]
patch

r=sspitzer

just a few comments / questions.

1)

-    "FROM moz_bookmarks a "
-    "JOIN moz_places h ON a.fk = h.id "

+     "FROM moz_bookmarks a "
+     "LEFT JOIN moz_places h ON a.fk = h.id "


To confirm my understanding: you switched from a JOIN to a LEFT JOIN because folders and separators are in moz_bookmarks table, but they are not in the moz_places table, right?

2) testSimplFolderResult

typo:  testSimplFolderResult -> testSimpleFolderResult

3)

just curious, why'd you choose about:blank for the uri in your test code?
  
(Are you simultaneously testing how we handle about:blank)

Comment 3

[Asaf Romano (gone)]

1) right
3) No goo reason, it is as good as foo.tld

Comment 4

[Asaf Romano (gone)]

mozilla/toolkit/components/places/src/nsNavBookmarks.cpp 1.89
mozilla/toolkit/components/places/tests/bookmarks/test_bookmarks.js 1.12

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv