Closed Bug 380519 Opened 17 years ago Closed 17 years ago

Don't use the moz_bookmarks.folderType field for marking the toolbar folder

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 alpha5

People

(Reporter: asaf, Assigned: asaf)

Details

Attachments

(2 files)

We use the folderType field of the moz_bookmarks table for marking the toolbar folder. The other possible values for this field are 1) empty string 2) a contractid, pointing to a class which implements nsIRemoteContainer.

One side effect of this implementation is the impossibility to mark a remote container as the toolbar folder; this is generally wrong IMO now that we have reliable item-annotations support in place.
Attached patch checkpointSplinter Review
Attached patch for alpha-5Splinter Review
Attachment #266683 - Flags: review?(dietrich)
Comment on attachment 266683 [details] [diff] [review]
for alpha-5

looks good, r=me
Attachment #266683 - Flags: review?(dietrich) → review+
mozilla/toolkit/components/places/src/nsAnnotationService.h 1.12
mozilla/toolkit/components/places/src/nsNavBookmarks.cpp 1.99
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: