380590 - WARNING: Don't call ContinueInterruptedParsing on a blocked parser.: file nsParser.cpp, line 1105

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Mats Palmgren (inactive)]

STEPS TO REPRODUCE
1. load URL
2. click in location bar
3. hit ENTER

ACTUAL RESULTS
WARNING: Don't call ContinueInterruptedParsing on a blocked parser.: file nsParser.cpp, line 1105

NOTE
The bug does not occur when clicking the Reload button.
The bug seems to occur on all story pages from http://news.bbc.co.uk/

PLATFORMS AND BUILDS TESTED
Bug occurs in SeaMonkey and Firefox trunk debug builds on Linux.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

The problem here is in nsContentSink::ContinueInterruptedParsingAsync: It unblocks the parser and then adds an event to the event queue to continue the interrupted parsing. If, between the time that we added the event and process it, we get a chunk of data with an external script in it, the parser will become blocked and when we do process the event, we'll hit this warning.

HTML: Parser isn't really the right component for this.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Easiest fix

This is the easiest fix: if we're about to continue parsing as a result of an event, ensure that the parser is still unblocked. If it's currently blocked, then whatever blocked it has the task of unblocking it now.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 265536 [details] [diff] [review]
Easiest fix

ContinueInterruptedParsingIfEnabled sounds like a better name for the new function.

r/sr=me with that

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: What I'm about to check in

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.