380602 - top left corner missing when -moz-border-radius-* is used

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[:Mook]

Attachment: testcase - should not have missing block at top left

This is a spinoff from bug 379474 comment 19, and bz says is a regression from bug 368247.

See testcase - the top left corner border is missing a chunk (looks to be about 1/2 of the border width?) when border-radius-* is used, where * != topleft.
Yes, it's always the top left corner that's missing.

Tested on 20070513/trunk/win32.

Comment 1

[:Mook]

Attachment: reference for reftest - the missing block covered by another div

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: fix

A fix.  We need to use ClosePath() to get the right join if there's no radius in the top-left corner -and- no sides are being skipped/not drawn.

Comment 3

[Boris Zbarsky [:bzbarsky]]

What if we did, say, skip the right side?  Wouldn't the bug remain in that case?

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #3)
> What if we did, say, skip the right side?  Wouldn't the bug remain in that
> case?

No, because the code will end up drawing bottom -> left -> top in that case, and there endpoints of the shouldn't be joined.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Ah, I'd missed that part of the code.  Very nice!

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Fixed by checked-in patch from bug 368247; the patch in this bug wasn't used.