Make nsTHashtable and childs null-param safe

RESOLVED WONTFIX

Status

()

Core
XPCOM
RESOLVED WONTFIX
11 years ago
5 years ago

People

(Reporter: Alfred Kayser, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

11 years ago
From bug 347752:
Doug Turner   2007-05-09 07:01:58 PDT:
did we fix BaseHashtable? 

This bandaide is fine, but the underlying crash should be addressed.

we should avoid crashing where possible as a rule.

Comment #13 [reply] Alfred Kayser  2007-05-09 07:24:34 PDT

As for BaseHashtable, I didn't dare to go yet in that direction because it is
used to many places to face the risk of performance impact and such...
And then it seems to be actually in nsTHashtable.h, that GetEntry and PutEntry
(and others) may need to be fixed:
http://lxr.mozilla.org/seamonkey/source/xpcom/glue/nsTHashtable.h#155

Comment 1

11 years ago
It's not a given that we should prevent invalid-param crashes, but in this case it probably will cost next to nothing.

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.