Closed Bug 380613 Opened 17 years ago Closed 17 years ago

Need serial comma after "canceled" in the tooltip for the Clean Up button.

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
minor

Tracking

()

VERIFIED FIXED

People

(Reporter: stephend, Assigned: reed)

References

()

Details

Attachments

(1 file)

Build ID: Today's trunk under Windows Vista.

Summary: The tooltip for the "Clean Up" button in the Download Manager needs some serial-comma loving.

Steps to Reproduce:

1. Mouse over the "Clean Up" button in the Download Manager.
2. Examine the tooltip's text.

Actual Results:

Tooltip reads, "Removes completed, canceled and failed downloads from the list"

Expected Results:

Tooltip reads, "Removes completed, canceled, and failed downloads from the list"

(http://www.protrainco.com/essays/serial-comma.htm provides me with ample ammo to suggest such a change.)
Whiteboard: [good first bug]
OS: Windows Vista → All
Hardware: PC → All
Attached patch patch - v1Splinter Review
Assignee: nobody → reed
Status: NEW → ASSIGNED
Attachment #265778 - Flags: review?(gavin.sharp)
Attachment #265778 - Flags: review?(gavin.sharp) → review+
Whiteboard: [good first bug] → [checkin needed]
Checking in toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd;
new revision: 1.6; previous revision: 1.5
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Verified FIXED using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a5pre) Gecko/20070525 Minefield/3.0a5pre; tooltip now correctly states, "Removes completed, canceled, and failed downloads from the
list"
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: