380632 - executing finally blocks for JSTRAP_RETURN

Status: RESOLVED INVALID

(Core :: JavaScript Engine, enhancement)

Description

[Igor Bukanov]

Currently when a various debug hooks return JSTRAP_RETURN, the interpreter skips the outstanding finally blocks. But this is unintuitive since it does not match the behavior of the return statement. Thus I suggest to change JSTRAP_RETURN so it  will execute the finally blocks and behave exactly as if a return instruction was injected into the bytecode.

Given the current infrastructure to support generator.close() it should be almost trivial to implement as the interpreter can just throw JSVAL_ARETUN instead of  jumping to the out label.

Comment 1

[Brendan Eich [:brendan]]

JSTRAP_RETURN and the JS debugger API pre-dates ES3-era work implementing try-catch-finally; apparently the latter work was done without considering the jsdbgapi. Glad you are on this.

/be

Comment 2

[Igor Bukanov]

I am not working on the bug.

Comment 3

[André Bargull [:anba]]

JSTRAP_RETURN is no longer present, therefore resolving as Invalid.