Closed Bug 380661 Opened 17 years ago Closed 17 years ago

switching sort between multiple custom columns doesn't work

Categories

(Thunderbird :: Mail Window Front End, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Details

(Keywords: verified1.8.1.5)

Attachments

(1 file)

If you add multiple custom columns to the thread pane, and switch back and forth sorting them, the sort fails because we don't realize that the actual column sorted by changes, since the sort type remains byCustom.
Attached patch proposed fixSplinter Review
it's easiest and safest not to assume anything about the custom column sorts (e.g., that one of the column values hasn't changed). This does that.
Attachment #264788 - Flags: superreview?(mscott)
Attachment #264788 - Flags: superreview?(mscott) → superreview+
Comment on attachment 264788 [details] [diff] [review]
proposed fix

safe simple fix that might help some extensions.
Attachment #264788 - Flags: approval1.8.1.5?
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment on attachment 264788 [details] [diff] [review]
proposed fix

approved for 1.8.1.5, a=dveditz for release-drivers
Attachment #264788 - Flags: approval1.8.1.5? → approval1.8.1.5+
fixed on 1.8.1 branch
Keywords: fixed1.8.1.5
verified fixed 1.8.1.5 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.5pre) Gecko/20070707 Thunderbird/2.0.0.5pre Mnenhy/0.7.5.0 ID:2007070807 using the "steps to reproduce" from comment #0 - works fine for me - adding verified keyword
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: