right click, "Reload live Bookmark" of livemark on personal toolbar adds blank items to the personal toolbar. it's a regression from bug #337868. I've got a fix for this bug in bug #337855. the problem is with itemInserted() in toolbar.xml. we need to check that the parent is toolbarFolder before calling insertNewItem().
11 years ago
Assignee: nobody → sspitzer
note, you need to have opened the livemark menu popup on the personal toolbar to see this.
Status: NEW → ASSIGNED
Comment on attachment 264885 [details] [diff] [review] patch I think the check you want it aParentNode == this._self.getResult().root, and then you don't need to comment on the livebookmark special case ;)
Attachment #264885 - Flags: review?(mano) → review-
Created attachment 265017 [details] [diff] [review] updated patch
Comment on attachment 265017 [details] [diff] [review] updated patch r=mano. the comment could be a little more generic though.
Attachment #265017 - Flags: review?(mano) → review+
Created attachment 266276 [details] [diff] [review] as checked in
Attachment #265017 - Attachment is obsolete: true
fixed. Checking in content/toolbar.xml; /cvsroot/mozilla/browser/components/places/content/toolbar.xml,v <-- toolbar.x ml new revision: 1.87; previous revision: 1.86 done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
verified with Windows trunk build from 20070620
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.