Last Comment Bug 380709 - collectstats.pl can't find ThrowCodeError when a failure occurs
: collectstats.pl can't find ThrowCodeError when a failure occurs
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: Reporting/Charting (show other bugs)
: 3.0
: All All
: -- minor (vote)
: Bugzilla 3.0
Assigned To: Frédéric Buclin
: default-qa
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-05-15 01:19 PDT by Adam Batkin
Modified: 2007-05-15 14:11 PDT (History)
0 users
mkanat: approval+
mkanat: approval3.0+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch, v1 (476 bytes, patch)
2007-05-15 08:04 PDT, Frédéric Buclin
mkanat: review+
Details | Diff | Splinter Review

Description Adam Batkin 2007-05-15 01:19:48 PDT
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/20070320 Firefox/2.0.0.3
Build Identifier: 3.0

Last night cron e-mailed me to report:
Undefined subroutine &main::ThrowCodeError called at ./collectstats.pl line 192.

Adding a "use Bugzilla::Error" to collectstats.pl solves this

Reproducible: Always

Steps to Reproduce:
1. break the permissions on data/mining
2. Run collectstats.pl 

Actual Results:  
"Undefined subroutine &main::ThrowCodeError called at ./collectstats.pl line 192."

Expected Results:  
"Unable to open the chart datafile ./data/mining/-All-."
Comment 1 Frédéric Buclin 2007-05-15 08:04:29 PDT
Created attachment 264880 [details] [diff] [review]
patch, v1
Comment 2 Frédéric Buclin 2007-05-15 14:10:47 PDT
tip:

Checking in collectstats.pl;
/cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v  <--  collectstats.pl
new revision: 1.61; previous revision: 1.60
done

3.0:

Checking in collectstats.pl;
/cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v  <--  collectstats.pl
new revision: 1.58.2.2; previous revision: 1.58.2.1
done
Comment 3 David Lawrence [:dkl] 2007-05-15 14:11:05 PDT
Comment on attachment 264880 [details] [diff] [review]
patch, v1

Patch applies cleanly. Code looks sane. Compiles and executes without error. Functions as expected as well.
r=dkl

Note You need to log in before you can comment on or make changes to this bug.