Closed Bug 380709 Opened 17 years ago Closed 17 years ago

collectstats.pl can't find ThrowCodeError when a failure occurs

Categories

(Bugzilla :: Reporting/Charting, defect)

Product:
Bugzilla
Component:
Reporting/Charting
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 3.0

People

(Reporter: adam, Assigned: LpSolit)

Details

Attachments

(1 file)

patch, v1
476 bytes, patch
mkanat
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/20070320 Firefox/2.0.0.3
Build Identifier: 3.0

Last night cron e-mailed me to report:
Undefined subroutine &main::ThrowCodeError called at ./collectstats.pl line 192.

Adding a "use Bugzilla::Error" to collectstats.pl solves this

Reproducible: Always

Steps to Reproduce:
1. break the permissions on data/mining
2. Run collectstats.pl 

Actual Results:  
"Undefined subroutine &main::ThrowCodeError called at ./collectstats.pl line 192."

Expected Results:  
"Unable to open the chart datafile ./data/mining/-All-."
Version: unspecified → 3.0
Attached patch patch, v1 — — Splinter Review 
Assignee: gerv → LpSolit
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

        Attachment #264880 -
        Flags: review?(dkl)

    
  
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 3.0

    
  

        Attachment #264880 -
        Flags: review?(dkl) → review+

    
  
Flags: approval3.0+
Flags: approval+

    
    

    
  
tip:

Checking in collectstats.pl;
/cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v  <--  collectstats.pl
new revision: 1.61; previous revision: 1.60
done

3.0:

Checking in collectstats.pl;
/cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v  <--  collectstats.pl
new revision: 1.58.2.2; previous revision: 1.58.2.1
done

Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 264880 [details] [diff] [review]
patch, v1

Patch applies cleanly. Code looks sane. Compiles and executes without error. Functions as expected as well.
r=dkl

          You need to log in
          before you can comment on or make changes to this bug.