The default bug view has changed. See this FAQ.

collectstats.pl can't find ThrowCodeError when a failure occurs

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
Reporting/Charting
--
minor
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Adam Batkin, Assigned: Frédéric Buclin)

Tracking

Bugzilla 3.0
Bug Flags:
approval +
approval3.0 +

Details

Attachments

(1 attachment)

476 bytes, patch
Max Kanat-Alexander
: review+
Details | Diff | Splinter Review
(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/20070320 Firefox/2.0.0.3
Build Identifier: 3.0

Last night cron e-mailed me to report:
Undefined subroutine &main::ThrowCodeError called at ./collectstats.pl line 192.

Adding a "use Bugzilla::Error" to collectstats.pl solves this

Reproducible: Always

Steps to Reproduce:
1. break the permissions on data/mining
2. Run collectstats.pl 

Actual Results:  
"Undefined subroutine &main::ThrowCodeError called at ./collectstats.pl line 192."

Expected Results:  
"Unable to open the chart datafile ./data/mining/-All-."
(Reporter)

Updated

10 years ago
Version: unspecified → 3.0
(Assignee)

Comment 1

10 years ago
Created attachment 264880 [details] [diff] [review]
patch, v1
Assignee: gerv → LpSolit
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #264880 - Flags: review?(dkl)
(Assignee)

Updated

10 years ago
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 3.0

Updated

10 years ago
Attachment #264880 - Flags: review?(dkl) → review+

Updated

10 years ago
Flags: approval3.0+
Flags: approval+
(Assignee)

Comment 2

10 years ago
tip:

Checking in collectstats.pl;
/cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v  <--  collectstats.pl
new revision: 1.61; previous revision: 1.60
done

3.0:

Checking in collectstats.pl;
/cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v  <--  collectstats.pl
new revision: 1.58.2.2; previous revision: 1.58.2.1
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 3

10 years ago
Comment on attachment 264880 [details] [diff] [review]
patch, v1

Patch applies cleanly. Code looks sane. Compiles and executes without error. Functions as expected as well.
r=dkl
You need to log in before you can comment on or make changes to this bug.