380749 - Crash [@ nsAccessibilityService::GetInfo] wth appending caption in table with binding

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, because of the use of enhanced privileges you need to download the testcase to your computer to get the crash.
It doesn't crash in branch builds.
If wanted, I can look for a regression range.

Talkback ID: TB32162797Y
nsAccessibilityService::GetInfo  [mozilla/accessible/src/base/nsaccessibilityservice.cpp, line 281]
nsAccessibilityService::CreateHyperTextAccessible  [mozilla/accessible/src/base/nsaccessibilityservice.cpp, line 531]
nsHTMLTableAccessible::GetCaption  [mozilla/accessible/src/html/nshtmltableaccessible.cpp, line 256]
nsHTMLTableAccessible::CacheChildren  [mozilla/accessible/src/html/nshtmltableaccessible.cpp, line 111]
nsAccessible::GetChildCount  [mozilla/accessible/src/base/nsaccessible.cpp, line 795]
NS_InvokeByIndex_P  [mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp, line 102]
XPCWrappedNative::CallMethod  [mozilla/js/src/xpconnect/src/xpcwrappednative.cpp, line 2245]

Comment 1

[Martijn Wargers (dead)]

The embedded xbl consists of this:
<?xml version="1.0"?>
<bindings xmlns="http://www.mozilla.org/xbl"
          xmlns:html="http://www.w3.org/1999/xhtml">
  <binding id="a">
    <content>
      <html:span style="display: none;"><children/></html:span>
    </content>
  </binding>
</bindings>

Comment 2

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Add missing null-check (2nd change).
Don't warn about tables without a caption (1st change), or null frame
for table cells (3rd change) because that's normal.

Comment 3

[Martijn Wargers (dead)]

Attachment: testcase

Aaron changed something in bug 268935 that makes the original testcase not work anymore.
This is the updated testcase, using nsIAccessibleRetrieval.

Comment 4

[Mats Palmgren (inactive)]

Checked in to trunk at 2007-05-17 01:21 PDT.

-> FIXED

Comment 5

[Martijn Wargers (dead)]

Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070517 Minefield/3.0a5pre