380798 - clicking on the 'Restore Default Set' changes icon view

Status: VERIFIED DUPLICATE of bug 350292

(Calendar :: Sunbird Only, defect)

Description

[Ray Kiddy]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.4pre) Gecko/20070514 Calendar/0.5pre

I have my toolbar in Calendar set to 'Icon and Text'. I prefer this but I think it was default. I do not remember setting it.

I tried adding some things to the toolbar from the contextual 'Customize' menu. That worked great. I clicked on 'Restore Default Set' and not only did it restore the default set, but it switched the view to 'Icon' only. I do not think it was ever the default, but even if it was, I wanted the default set, not the view.

Comment 1

[Stefan Sitter [:ssitter]]

This was fixed with Bug 350292 for Trunk only builds and required changes in Toolkit and Firefox (Bug 359656, Bug 363043, Bug 363098, ...). 

I doubt that this will be rate a security fix and will be fixed for mozilla1.8 branch (Sunbird 0.5) too. 

Comment 2

[cmtalbert]

So, it sounds like this is a valid bug, and maybe should be remain as a placeholder.  But it also sounds like this should be duped against the relevant toolkit bugs.  Stefan, Ray, others, thoughts?

Comment 3

[Stefan Sitter [:ssitter]]

Phil, do you remember all changes and bugs that were necessary to make the toolbar customization dialog working properly in Sunbird? I mentioned some of them in Comment #1 but I'm not sure if this are all bugs.

Comment 4

[Phil Ringnalda (:philor)]

To get restore default set to restore default size and mode, you should only need attachment 247776 [details] [diff] [review] (which you aren't likely to get on 1.8, since as you say it affects Firefox - for the better, but still...).

Of course, that's not what Ray wants, but I'm not quite sure what really ought to be expected there: Mac customization, where we stole it, doesn't have a button to restore default state, just a set of default icons you can drag.

Comment 5

[cmtalbert]

This is essentially the same as bug 350292, and isn't going to be fixed on branch.