380831 - Incorrect uneval trying to output a getter function that is a sharp definition

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

One of the testcases mentioned in bug 358594 is still not handled correctly:

js> a = {}; h = function() { }; a.b getter = h; a.c = h; uneval(a);
({b getter:#1=() {}, c:#1#})

It's missing the "function" keyword in the anonymous-function expression.

(
Before the patch in bug 358594, the output was even worse: 
({get b #1=() {}, c:#1#})
)

Comment 1

[Brian Crowder]

Attachment: implementation v1

So we need to "sharpen" variables before we start thinking about chopping them up for syntactic reasons.  The sharpen step tells us whether or not we need old-style getter/setters and so prevents us mistakenly slicing "(function " off of "#1#", since we never do that hackery with old-style getter/setter.

Comment 2

[Igor Bukanov]

I am taking few days off and will review the patch after Monday.

Comment 3

[Brian Crowder]

Attachment: unbitrotted

This is just the same as before, but unbitrotted.  Worth reviewing, but don't expect a lot of differences.  I have run the test-suite both with and without this patch and no differences occur.

Comment 4

[Brian Crowder]

jsobj.c: 3.351

Comment 5

[Bob Clary [:bc] (inactive)]

/cvsroot/mozilla/js/tests/js1_5/extensions/regress-380831.js,v  <--  regress-380831.js
initial revision: 1.1

Comment 6

[Bob Clary [:bc] (inactive)]

verified fixed 1.9.0 linux/mac*/windows.