380889 - Source note disassembler assumes SRC_SWITCH always has jump table

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Igor Bukanov]

Consider the following session for a debug build of js shell:

~/m/trunk/mozilla/js/src $ cat ~/m/y.js
function f(i)
{
  switch(i){
    case 1:
    case xyzzy:
  }
}

dis(f);
~/m/trunk/mozilla/js/src $ ./Linux_All_DBG.OBJ/js ~/m/y.js
main:
00000:  getarg 0
00003:  condswitch
00004:  one
00005:  case 17 (12)
00008:  name "xyzzy"
00011:  case 17 (6)
00014:  default 17 (3)
00017:  stop

Source notes:
  0:     0 [   0] newline 
Assertion failure: op == JSOP_LOOKUPSWITCH, at js.c:939
trace/breakpoint trap

The assert happens since the disassembler "forgot" that the [condswitch] bytecode also has SRC_SWITCH note.

Comment 1

[Igor Bukanov]

Attachment: fix v1

Comment 2

[Igor Bukanov]

I committed the patch from comment 1 to the trunk:

Checking in js.c;
/cvsroot/mozilla/js/src/js.c,v  <--  js.c
new revision: 3.142; previous revision: 3.141
done

Comment 3

[Bob Clary [:bc] (inactive)]

Checking in regress-380889.js;
/cvsroot/mozilla/js/tests/js1_5/extensions/regress-380889.js,v  <--  regress-380889.js
initial revision: 1.1

Comment 4

[Bob Clary [:bc] (inactive)]

verified fixed 1.9.0 linux/mac*/windows.