Status

()

Core
JavaScript Engine
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: bc, Assigned: bc)

Tracking

({meta, verified1.8.1.8})

Trunk
meta, verified1.8.1.8
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

10 years ago
 
Flags: in-testsuite-
(Assignee)

Updated

10 years ago
Depends on: 355044
(Assignee)

Comment 1

10 years ago
Created attachment 283178 [details] [diff] [review]
update 1.8.1 JS_GetImplementationVersion
Attachment #283178 - Flags: review?(brendan)
Attachment #283178 - Flags: approval1.8.1.8?
(Assignee)

Comment 2

10 years ago
Created attachment 283179 [details] [diff] [review]
update trunk JS_GetImplementationVersion
Attachment #283179 - Flags: review?(brendan)
Attachment #283179 - Flags: approval1.9?
(Assignee)

Comment 3

10 years ago
Created attachment 283180 [details] [diff] [review]
update trunk JS_GetImplementationVersion

Actually, it makes better sense to update the version of SpiderMonkey on the trunk to 1.8.0 rather than the 1.7.1.
Attachment #283179 - Attachment is obsolete: true
Attachment #283180 - Flags: review?(brendan)
Attachment #283180 - Flags: approval1.9?
Attachment #283179 - Flags: review?(brendan)
Attachment #283179 - Flags: approval1.9?
Comment on attachment 283178 [details] [diff] [review]
update 1.8.1 JS_GetImplementationVersion

Code freeze is tomorrow, Brendan please r+ soon if you want this to be tagged with 1.8.1.8

Updated

10 years ago
Attachment #283178 - Flags: review?(brendan) → review+

Updated

10 years ago
Attachment #283180 - Flags: review?(brendan)
Attachment #283180 - Flags: review+
Attachment #283180 - Flags: approval1.9?
Attachment #283180 - Flags: approval1.9+
Comment on attachment 283178 [details] [diff] [review]
update 1.8.1 JS_GetImplementationVersion

approved for 1.8.1.8, a=dveditz for release-drivers
Attachment #283178 - Flags: approval1.8.1.8? → approval1.8.1.8+
(Assignee)

Comment 6

10 years ago
attachment 283180 [details] [diff] [review] checked into the trunk.

Checking in jsapi.c;
/cvsroot/mozilla/js/src/jsapi.c,v  <--  jsapi.c
new revision: 3.361; previous revision: 3.360
done
Status: NEW → ASSIGNED
Flags: in-litmus-
(Assignee)

Comment 7

10 years ago
attachment 283178 [details] [diff] [review] checked into 1.8 branch.

Checking in jsapi.c;
/cvsroot/mozilla/js/src/jsapi.c,v  <--  jsapi.c
new revision: 3.214.2.38; previous revision: 3.214.2.37
done
Keywords: fixed1.8.1.8

Comment 8

10 years ago
v.fixed for 1.8.1.8 by code inspection, simple enough.
Keywords: fixed1.8.1.8 → verified1.8.1.8

Comment 9

10 years ago
can this be resolved FIXED?
Prolly bclary is keeping this open until the standalone release is done. Why do you care? It's not on the 1.9 radar I hope.

/be

Comment 11

10 years ago
We were just going through looking at bugs with approval flags that were still open.  No worries just wasn't clear if this had been left open by accident or not.
(Assignee)

Comment 12

10 years ago
I'm waiting for Firefox 2.0.0.8 to ship, then will create a tag based on the release tag for the SpiderMonkey release. 
(Assignee)

Updated

10 years ago
Depends on: 400706
(Assignee)

Comment 13

10 years ago
RCS file: /www/mozilla-org/html/js/spidermonkey/release-notes/JS_170.html,v
done
Checking in JS_170.html;
/www/mozilla-org/html/js/spidermonkey/release-notes/JS_170.html,v  <--  JS_170.html
initial revision: 1.1
done
Checking in NOMENU;
/www/mozilla-org/html/js/spidermonkey/release-notes/NOMENU,v  <--  NOMENU
new revision: 1.2; previous revision: 1.1
done
Checking in index.html;
/www/mozilla-org/html/js/spidermonkey/release-notes/index.html,v  <--  index.html
new revision: 1.26; previous revision: 1.25
done

Email sent to mozilla.announce and mozilla.dev.tech.js-engine. 

Bug 401087 will track bugs for next release of SpiderMonkey 1.7.1 around 1.8.1.10.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.