380919 - Format of nsILoginInfo "hostname" property is confusing

Status: RESOLVED DUPLICATE of bug 379111

(Toolkit :: Password Manager, enhancement)

Description

[Justin Dolske [:Dolske]]

The format of the .hostname property (and its usage throughout the login manager) is confusing. This was inherited from the old password manager, and not specifically addressed during the JS rewrite.

For form logins, the format must be "http://www.site.com". The port isn't specified by default, and since the whole thing is a string it's probably easy to break if something uses "http://foo.com" in one place and "http://foo.com:80" in another. [ie, there's no knowledge of the default port used.]

For HTTP logins, the format must be "www.site.com:80". No scheme ("http://") is specified, and the port must always be specified.

There should probably be a separate flag to indicate if the password is only to be sent over SSL (ie, when the password was stored it was being submitted securely). That may or may not be outside the scope of this bug.