380951 - when editing bookmark, only call setKeywordForBookmark if new != old

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

when editing bookmark, only call setKeywordForBookmark if new != old

the common case is when editing bookmarks without keywords.

this can happen if you edit a bookmark without a keyword, by change the title (or description), we

I think we should fix both the doTransaction and the undoTransaction in PlacesEditBookmarkKeywordTransaction to do nothing if the keyword hasn't changed.

additionally, see nsNavBookmarks::SetKeywordForBookmark().

It looks like we need to initalize keywordId (to 0?) so that when the keyword is empty we update moz_bookmarks table.  right now, since keywordId is an uninitialized PRInt64, we could be setting it to garbage.

Comment 1

[Asaf Romano (gone)]

Like other transactions, we better fix the caller(s).

The second fix seems right.

Comment 2

[(not reading, please use [e-mail] instead)]

> Like other transactions, we better fix the caller(s).

good point.  I'll morph this bug to cover that issue.

> The second fix seems right.

now covered by bug #377281

Comment 3

[Dietrich Ayala (:dietrich)]

this is fixed in bookmark overlay, which is now used in all add-bookmark UI.

Comment 4

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv