380959 - uneval(window) gives me something I can't pass to eval

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

javascript:a = 3; alert(uneval(window));

result: "{}"

expected: at least something I can pass to eval, such as "({})", but "({a:3})" would be nice.

Comment 1

[Jesse Ruderman]

Attachment: patch changing {} to ({})

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 382206 [details] [diff] [review]
patch changing {} to ({})

>diff --git a/js/src/xpconnect/src/xpcwrappednativejsops.cpp b/js/src/xpconnect/src/xpcwrappednativejsops.cpp
>+    static const char empty[] = "({})";

This is fine. It'll end up with extra parens in, e.g. uneval({a:window}) => ({a: ({})}) but that's better than too few parentheses stopping compilation altogether!

>     *vp = STRING_TO_JSVAL(JS_NewStringCopyN(cx, empty, sizeof(empty)-1));

Please make this:

JSString *str = JS_NewStringCopyN(cx, empty, sizeof(empty)-1);
if(!str)
    return JS_FALSE;
*vp = STRING_TO_JSVAL(str);

>     return JS_TRUE;
> }

Comment 3

[Jesse Ruderman]

Fixed:

http://hg.mozilla.org/mozilla-central/rev/efc54e3f494c

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Was this individually landed on TM branch? (whatever the case, it eventually will be once m-c gets synchronized onto TM branch)

Comment 5

[Jesse Ruderman]

No, I only landed this on mozilla-central.  It's in DOM/XPConnect code, not JavaScript Engine code.