Closed Bug 380988 Opened 17 years ago Closed 17 years ago

Label_for/Label_by relation is missing in creating new mailing list window.

Categories

(MailNews Core :: Address Book, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tim.miao, Assigned: standard8)

Details

(Keywords: access)

Attachments

(4 files)

Steps to reproduce:
1. Launch thunderbird and open address book.
2. Create a new mailing list.
3. Invoke at-poke, poke this mailing list edit window.

Bug observation:
Label "Type email address to add them to the mailing list:" has no label_for object, and the list table has no Labeled_by object.

Additional info:
This bug can be found with thunderbird 20070515 trunk build.
This bug can be found with message filters window too. The lable of filter table and the filter table have no label_for/labeled_by relations.
Problem will exist in both SeaMonkey and Thunderbird as neither of them have the control specified for the label in the mailing list dialogs. Therefore moving to core address book.
Assignee: mscott → nobody
Component: General → MailNews: Address Book
Product: Thunderbird → Core
QA Contact: general → addressbook
This bug can be found in following thunderbird places:
RSS: manage rss subscriptions window:
   Label: "Note: Removing or changing..."
   Table: RSS feeds table

   Label: "Title", "Location"
(In reply to comment #3)
> This bug can be found in following thunderbird places:
> RSS: manage rss subscriptions window:
>    Label: "Note: Removing or changing..."
>    Table: RSS feeds table
>    Label: "Title", "Location"

Please raise seperate bugs for those, or have one for each area of Thunderbird where these problems exist.
Filed bug #381117 for comment #4.
SeaMonkey fix (-w version).

I took one look at the file and decided to do a whitespace clean up. Full patch in a mo.

I'll do the Thunderbird fix later (I've still got to test it).
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #265286 - Flags: review?(neil)
Comment on attachment 265286 [details] [diff] [review]
Fixes SeaMonkey (diff -w)

>-	<label value="&AddressTitle.label;"/>
>+  <label control="addressingWidget" value="&AddressTitle.label;"/>
> 	<spacer style="height:0.1em"/>
> 
> 	<listbox id="addressingWidget" style="height: 15em;"
This is the only real change, right?
Attachment #265286 - Flags: review?(neil) → review+
(In reply to comment #8)
> (From update of attachment 265286 [details] [diff] [review])
> >-	<label value="&AddressTitle.label;"/>
> >+  <label control="addressingWidget" value="&AddressTitle.label;"/>
> > 	<spacer style="height:0.1em"/>
> > 
> > 	<listbox id="addressingWidget" style="height: 15em;"
> This is the only real change, right?
> 
Yep.
Attachment #265354 - Flags: superreview?(mscott)
Attachment #265354 - Flags: review?(mscott)
Attachment #265354 - Flags: superreview?(mscott)
Attachment #265354 - Flags: superreview+
Attachment #265354 - Flags: review?(mscott)
Attachment #265354 - Flags: review+
Attached file patch
(In reply to comment #11)
> Created an attachment (id=265412) [details]
> patch
> 

Sorry, you'll find I've already done the patches for this bug and got reviews if you read the previous attachments/comments. Though yours does have the same effect. Note also that you should select the patch option and not text/x-patch when attaching to bugzilla as its easier for people to view and enables the diff options.
Attachment #265287 - Attachment description: Fixes SeaMonkey (full patch) → Fixes SeaMonkey (full patch - checked in)
Attachment #265354 - Attachment description: Fixes Thunderbird → Fixes Thunderbird (checked in)
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Sorry, I neglected it when I attached the patch on Sunday :-)
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: