380993 - onStateChange reports all 5 state values (0 to 4) even if install.js calls cancelInstall

Status: RESOLVED INVALID

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Georg Maaß]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.13) Gecko/20060414
Build Identifier: 

onStateChange reports all 5 state values (0 to 4) even if install.js calls cancelInstall. In case of cancelInstall I expect only the state values 0 to 2 and 4 but not 3.


DOWNLOAD_START  = 0
DOWNLOAD_DONE     = 1
INSTALL_START     = 2
INSTALL_DONE     = 3
DIALOG_CLOSE     = 4



Reproducible: Always

Steps to Reproduce:
Do an installation of multiple packages each having its own install.js. Do it using the install manager:

var obj = {onProgress: onProgress, onStateChange: onStateChange};
var xpimgr = Components.classes["@mozilla.org/xpinstall/install-manager;1"].createInstance(Components.interfaces.nsIXPInstallManager);
xpimgr.initManagerFromChrome(files, files.length, obj);


Actual Results:  
Even if one or more packages call cancelInstall() in their install.js each of them reports the state sequence of 0 ... 3 in the callbacks to onStateChange and one reports all 5 state values (0 ... 4)

Expected Results:  
Only packages running performInstall() with success are expected to report state 3 when calling back onStateChange

The actual behaviour causes the application that invokes the installation to assume full success even in case of total failure. The only thing that gives me any hint that there was a problem is the install.log file.

The problems occure with XULRunner 1.9a5 on WindowsXP. Not yet tested on other platforms.

Comment 1

[Georg Maaß]

The behaviour does not match the documentation of http://www.xulplanet.com/references/xpcomref/ifaces/nsIXPIProgressDialog.html#method_onStateChange

Comment 2

[Georg Maaß]

This bug is outdated, because install.js is no longer supported on 1.9.0 and newer releases.