Integrate Scriptaculous Test Suite

RESOLVED FIXED

Status

()

Core
DOM
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: John Resig, Assigned: John Resig)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

unspecified
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

11 years ago
Created attachment 265105 [details] [diff] [review]
Scriptaculous Test Suite Patch

This is the integration of the Scriptaculous test suite into the Mozilla (and Mochitest) test suite.

Since releases of Scriptaculous aren't tagged, this is the equivalent to SVN r6710. This is meant to go along with the other Ajax libraries being tested. (This specific patch should be applied in mozilla/dom/tests/mochitest/ajax/)

All of the test files are included with the exception of two: slider_test.html (because it currently errors out in Firefox 2 and Trunk) and bdd_test.html (because it doesn't use the correct callback scheme that the rest of the suite uses). Additionally, there is one image file that will be attached separately.

This patch adds 893 new tests to the automated test suite.
Attachment #265105 - Flags: review?(sayrer)
(Assignee)

Comment 1

11 years ago
Created attachment 265106 [details]
Test Image

This is a binary image that needs to be included with the suite. Specifically, this file should go in: mozilla/dom/tests/mochitest/ajax/scriptaculous/test/unit/
Attachment #265106 - Flags: review?(sayrer)

Comment 2

11 years ago
Comment on attachment 265105 [details] [diff] [review]
Scriptaculous Test Suite Patch

I'm not going to review all the JS code, but I assume it has been tested and is passing. Makefiles look good.
Attachment #265105 - Flags: review?(sayrer) → review+

Updated

11 years ago
Attachment #265106 - Flags: review?(sayrer) → review+
Has this been tested on linux? :)
(Assignee)

Comment 4

11 years ago
Created attachment 268272 [details] [diff] [review]
Scriptaculous Test Suite Patch

New version of the test suite. Removed the autocomplete test (it was quite flaky) and generated a new -u9p diff. Tested under Linux and OS X. (Expects the Mochikit test suite patch to be applied before this one.)
Attachment #265105 - Attachment is obsolete: true
Attachment #268272 - Flags: review?(rcampbell)
Comment on attachment 268272 [details] [diff] [review]
Scriptaculous Test Suite Patch

tested locally on linux. Built and passed all tests.
Attachment #268272 - Flags: review?(rcampbell) → review+
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Flags: in-testsuite+
(Assignee)

Updated

10 years ago
Blocks: 424816
Assignee: nobody → jresig
Component: Testing → DOM
QA Contact: testing → general
Depends on: 562083
You need to log in before you can comment on or make changes to this bug.