381001 - Integrate Scriptaculous Test Suite

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[John Resig]

Attachment: Scriptaculous Test Suite Patch

This is the integration of the Scriptaculous test suite into the Mozilla (and Mochitest) test suite.

Since releases of Scriptaculous aren't tagged, this is the equivalent to SVN r6710. This is meant to go along with the other Ajax libraries being tested. (This specific patch should be applied in mozilla/dom/tests/mochitest/ajax/)

All of the test files are included with the exception of two: slider_test.html (because it currently errors out in Firefox 2 and Trunk) and bdd_test.html (because it doesn't use the correct callback scheme that the rest of the suite uses). Additionally, there is one image file that will be attached separately.

This patch adds 893 new tests to the automated test suite.

Comment 1

[John Resig]

Attachment: Test Image

This is a binary image that needs to be included with the suite. Specifically, this file should go in: mozilla/dom/tests/mochitest/ajax/scriptaculous/test/unit/

Comment 2

[Robert Sayre]

Comment on attachment 265105 [details] [diff] [review]
Scriptaculous Test Suite Patch

I'm not going to review all the JS code, but I assume it has been tested and is passing. Makefiles look good.

Comment 3

[Rob Campbell [:rc] (:robcee)]

Has this been tested on linux? :)

Comment 4

[John Resig]

Attachment: Scriptaculous Test Suite Patch

New version of the test suite. Removed the autocomplete test (it was quite flaky) and generated a new -u9p diff. Tested under Linux and OS X. (Expects the Mochikit test suite patch to be applied before this one.)

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 268272 [details] [diff] [review]
Scriptaculous Test Suite Patch

tested locally on linux. Built and passed all tests.