381041 - Shift-Del Behavior Should Work On Toolbar Button and Menus

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[David White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: 20070221

I have read and confirmed that when I press the key combo SHIFT-DELETE, selected messages are deleted from their folder by-passing the Trash folder. This is a good thing in many cases! However, I note that pressing SHIFT while clicking the DELETE toolbar button does NOT mimic this behavior - mail always seems to go to the Trash folder. Also, the Delete Message/Delete Selected Messages context menu item does not mimic this behavior. Shouldn't the shift-delete semantics always be the same?

Reproducible: Always

Comment 1

[Magnus Melin [:mkmelin]]

There is an old suite bug for this (bug 49323), bug couldn't find one for thunderbird, so confirming. 

Comment 2

[Asa Dotzler [:asa]]

Scott, this seems like it would be a pretty easy fix. Any chance you could put it on a todo list somewhere? I use and love the keyboard shortcut, but miss it when I'm in mouse mode. 

Comment 3

[Bruno 'Aqualon' Escherl]

I'm working on the SeaMonkey bug at the moment. The patch can probably be ported when it's done.

Comment 4

[Scott MacGregor]

Maybe Magnus or Phil want to take a stab at this.

Comment 5

[Bruno 'Aqualon' Escherl]

Attachment: TB version of SM patch in bug 49323

This is the same fix as in bug 49323. Note: I don't build TB myself, so it's not tested.

Comment 6

[Scott MacGregor]

Comment on attachment 276364 [details] [diff] [review]
TB version of SM patch in bug 49323

I'll steal this review from David. The patch looks great, thanks for porting it to Thunderbird!

Comment 7

[Phil Ringnalda (:philor)]

mail/base/content/mailWindowOverlay.xul 1.219