38110 - Composer Colorpicker: Allow user to select a color not in color swatch table

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[Matthew Leung]

Composer crahses after you put your mouse on the custom color text box

Comment 1

[Jesse Ruderman]

The color dialog is the third item from the left in composer.  After you click 
on it, you can select a color from a rectangle, or you can click on a textbox 
(probably to enter a hex value).  Clicking this textbox causes the (Win98) 
titlebar to rapidly gain and lose focus for about a second, and then crashes 
mozilla.

MOZILLA caused a stack fault in module JS3250.DLL at 015f:60baac15.
Registers:
EAX=007b1ec0 CS=015f EIP=60baac15 EFLGS=00010206
EBX=0086a460 SS=0167 ESP=00592000 EBP=0059200c
ECX=008d51d0 DS=0167 ESI=01c8a648 FS=3217
EDX=01c8a648 ES=0167 EDI=008cb380 GS=0000
Bytes at CS:EIP:
57 8b 16 89 45 0c 8d 7a 24 89 7d fc b8 00 00 00 
Stack dump:
01c8a648 0086a460 008d51d0 005920e8 60b922a0 008cb380 01c8a648 00000002 
60bee289 008cb380 01c8a648 008cb380 01c8a648 60bf9ae2 008cb380 01c8a648 

Comment 2

[R.K.Aa.]

likely related to bug 35100

Comment 3

[Claudius Gayle]

don't know how this got to 'bookmarks' blindly reassigning

Comment 4

[rubydoo123]

assigning this to Charley

Comment 5

[Charles Manske]

Yes, it is definitely related to bug 35100 and keyboard focus issues in 
<popup> menus. Hyatt says this is a difficult problem.
In WinNT, I don't crash, but I don't get focus and thus cannot type in the
editbox. If not fixed for beta2, we will disable the textfield

Comment 6

[Charles Manske]

 add depends on 35100

Comment 7

[Andreas Franke (gone)]

I don't see a crash on PC/Linux with any build.
Changing OS to Win98 per Jesse's comments.

Comment 8

[rubydoo123]

updated priority and severity

Comment 9

[R.K.Aa.]

bug 35100 was verified fixed on May 24th.
Did that fix this too?

Comment 10

[Charles Manske]

The fix for 35100 doesn't fix the problem of not being able to use a
textfield in the popup.
I'm changing summary to reflect the remaining issue of how to let user
select a color that is not in the color swatch table.

Comment 11

[Charles Manske]

This will require some additional UI : some short strings and probably buttons.
Marking nsbeta2 to ask this of PDT:
What is the cutoff for new UI: beta2 or beta3?
It might be wise to decide on a solution and add the strings, but not use them 
for nsbeta2 -- leave UI implemetation and testing for beta3.

Comment 12

[Jay Patel [:jay]]

Putting on [nsbeta2-] radar. Not critical to beta2. Deadline for any new 
features has already passed.

Comment 13

[rubydoo123]

this will not be in for first release, moving this out to future. If the user 
wants to modify the color, they can utilize the advanced option or edit HTML 
Source.

Comment 14

[Charles Manske]

Fixed with new color picker dialog.

Comment 15

[James "Kovu" Russell]

Clicking the text box in Composer's color picker produces the desired result, no
crash. verifying.