Closed Bug 381138 Opened 18 years ago Closed 13 years ago

Fix all uses of nsUnescape(temp.BeginWriting())

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: sharparrow1, Unassigned)

References

(
URL
)

Details

The pattern nsUnescape(temp.BeginWriting()) and related patterns are used all over the codebase, especially in mailnews. It ends up being safe most of the time becacuse only the pointer is used, but this pattern is incorrect because it leaves the unescaped string with an incorrect length. Most, although not all, of the instances of this pattern could be replaced with NS_UnescapeURL, which does the right thing; I'm not sure if that's the right way to go, though. Not sure who I need to CC.
A quick code grep says this isn't a problem any more.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
Component: String → XPCOM
You need to log in before you can comment on or make changes to this bug.