381255 - Drag and Drop to Bookmarks result in an Assertion failed

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Carsten Book [:Tomcat]]

Attachment: assertion

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a5pre) Gecko/20070519 Minefield/3.0a5pre ID:2007051900 [cairo] from experimental tinderbox.

ASSERT: Inseration point for menupopup view during a drag must be -1 (see screenshot)

STR: take a url from the url bar and try to drop the url into the bookmark menu. Don`t open the Bookmark Menu and also result in this assertion.

Comment 1

[Ria Klaassen (not reading all bugmail)]

I think this is a dupe of / related to bug 337761.

Comment 2

[Modex]

Attachment: Screenshot #2

My version of stack trace

Comment 3

[Modex]

My OS WinXP + SP2
UA: Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.9a5pre) Gecko/20070521 Minefield/3.0a5pre

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

See also bug 383571 (might be related).

Comment 7

[(mostly gone) XtC4UaLL [:xtc4uall]]

trying the STRs with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008021304 Firefox/3.0.0.0 ID:2008021304 i don't get an assertion, just the bookmark menu isn't opening, but the bookmark is being added in the end.

Comment 8

[Serge Gautherie (:sgautherie)]

Carsten,
Were you still seeing the assertion in Gecko/2008022604 ?
Was it fixed by Gecko/2008022704 ?
"Or" do you confirm comment 7 (= the assertion was already fixed) ?
Or is it still there ?

The menu not opening is/was bug 337761 !

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to comment #8)
> Carsten,

Or someone else.

> Were you still seeing the assertion in Gecko/2008022604 ?
> Was it fixed by Gecko/2008022704 ?

These dates are from regular nightlies (related to bug 389931 fix),
not "experimental tinderbox" builds...

Comment 10

[Marco Bonardo [:mak]]

Attachment: patch

the only problem i still see here is a 

Error: aPopup is undefined
Source file: chrome://browser/content/places/menu.xml
Line: 494

in the error console, when dropping directly onto "bookmarks" in the main menu bar, still dropping works fine... 
dropping inside a menupopup is working here, most probably because of recent work onto the menupopup binding and target corrections.
Moreover the code that generated that assertion is gone during those changes.

About the remaining error, we are calling rebuild without passing in the popup name, but actually we don't really need to rebuild, iteminserted feels like doing a good work by itself. I've done some cleanup.

Comment 11

[Asaf Romano (gone)]

Comment on attachment 307558 [details] [diff] [review]
patch

r=mano

Comment 12

[Dietrich Ayala (:dietrich)]

Checking in browser/base/content/browser-places.js;
/cvsroot/mozilla/browser/base/content/browser-places.js,v  <--  browser-places.js
new revision: 1.112; previous revision: 1.111
done

Comment 13

[Tracy Walker [:tracy]]

verified with: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre)
Gecko/2008032106 Minefield/3.0b5pre

Comment 14

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv