381281 - Can't reorder bookmarks

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070519 Minefield/3.0a5pre ID:2007051902 [cairo]

repro:
Open FF
Open Bookmarks Menu (or manager)
try to drag a bookmark to another place

result:
doesn't work
no message in errorconsole

strangely enough it works on the bookmarks toolbar

Comment 1

[Carsten Book [:Tomcat]]

wfm on Vista with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a5pre) Gecko/20070519 Minefield/3.0a5pre ID:2007051904 [cairo] i can move bookmarks around (from bookmark manager to toolbar or on different bookmark folders)

Comment 2

[Peter van der Woude [:Peter6]]

after a restart I get some lines in errorconsole when i reorder a bookmark in Menu or Manager

Warning: reference to undefined property this._controller
Source file: chrome://browser/content/places/menu.xml
Line: 541

Error: folder has no properties
Source file: chrome://browser/content/places/tree.xml
Line: 693

Comment 3

[Peter van der Woude [:Peter6]]

in Bookmarks Manager I can reorder (drag) a bookmark from one folder to another, providing they are not parent/child

In Bookmarks menu nothing works

Comment 4

[Ria Klaassen (not reading all bugmail)]

Doesn't work here either. Not even with the default set in a freshly created profile.

Comment 5

[Ria Klaassen (not reading all bugmail)]

The same with Vista, also tested with the default set in a new profile.

Comment 6

[Peter van der Woude [:Peter6]]

Mano, should I file a separate bug for each bookmark part ( Bookmarks Manager - Bookmarks Toolbar - Bookmarks Sidebar - Bookmarks Menu) or simply keep it all together here ?

Comment 7

[Asaf Romano (gone)]

Let's keep it all here for now, thanks Peter.

Comment 8

[Ria Klaassen (not reading all bugmail)]

It still worked fine in a 18 December 2006 places build, although some people saw the menu close while dragging (Bug 333602).

Comment 9

[Asaf Romano (gone)]

Attachment: fix trees

Comment 10

[Peter van der Woude [:Peter6]]

(In reply to comment #9)
> Created an attachment (id=265421) [details]
> fix trees
> 
This fixes the issues in Manager and Sidebar, but not in Bookmarks Menu (can't drag)

This is what I get if I try to drag in Menu:
Warning: reference to undefined property this._controller
Source file: chrome://browser/content/places/menu.xml
Line: 543

Comment 11

[Asaf Romano (gone)]

Attachment: well, that too

Note that d&d is still kinda buggy (esp. in menus).

Comment 12

[pal-moz]

how about bug#380246 ?
dupe ?

Comment 13

[Peter van der Woude [:Peter6]]

(In reply to comment #11)
> Created an attachment (id=265423) [details]
> well, that too
> 
> Note that d&d is still kinda buggy (esp. in menus).
> 
Yeah I know.
With the changes in menu.xml the Bookmarks Menu d&d is working again.

Comment 14

[Peter van der Woude [:Peter6]]

(In reply to comment #12)
> how about bug#380246 ?
> dupe ?
> 
It works with the patch of this bug, but I get errors in nsDragAndDrop.js so it's not fully resolving bug 380246

Comment 15

[(not reading, please use [e-mail] instead)]

Comment on attachment 265423 [details] [diff] [review]
well, that too

r=sspitzer

Comment 16

[(not reading, please use [e-mail] instead)]

from irc:

<Mano> the result is kept in the view
<Mano> see getResult()
<Mano> so we first null out the viewer on the result
<Mano> and then null the view
<Mano> this breaks the (very confusing) cycle we've there

can you add that as a comment to the destructor in tree.xml?

Comment 17

[Asaf Romano (gone)]

Attachment: as checked in

Comment 18

[Asaf Romano (gone)]

mozilla/browser/components/places/content/menu.xml 1.71
mozilla/browser/components/places/content/tree.xml 1.68

Comment 19

[Al Billings [:abillings - ex-MoCo]]

I can't drag in the Bookmark menu but then I can't do that in 2.0.0.5 either. Is that a valid scenario?

Dragging in Bookmarks Manager and Sidebar are verified in Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200707270404 Minefield/3.0a7pre though.

Comment 20

[Christine Yen]

(In reply to comment #19)
> I can't drag in the Bookmark menu but then I can't do that in 2.0.0.5 either.
> Is that a valid scenario?
> 
> Dragging in Bookmarks Manager and Sidebar are verified in Mozilla/5.0
> (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200707270404
> Minefield/3.0a7pre though.
> 

Yeah, that's why bug 380301 (which deals with dragging items within the bookmarks menu) is Windows-only. Items aren't supposed to be draggable within Mac menus, I suppose...

Comment 21

[Tracy Walker [:tracy]]

I can dnd bookmarks within the menu until I try to do bug 380301, after which it becomes broken.  Restart the browser corrects the broken state.

verified with: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007073005 Minefield/3.0a7pre

we need an entire group of dnd test cases in litmus

Comment 22

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 23

[Tracy Walker [:tracy]]

removing ancient in-testsuite requests