Can't reorder bookmarks

VERIFIED FIXED in Firefox 3 alpha5

Status

()

Firefox
Bookmarks & History
P2
normal
VERIFIED FIXED
11 years ago
4 years ago

People

(Reporter: Peter6, Assigned: mano)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 3 alpha5
x86
Windows XP
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

11 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070519 Minefield/3.0a5pre ID:2007051902 [cairo]

repro:
Open FF
Open Bookmarks Menu (or manager)
try to drag a bookmark to another place

result:
doesn't work
no message in errorconsole

strangely enough it works on the bookmarks toolbar
(Reporter)

Updated

11 years ago
Summary: Can't move bookmarks → Can't reorder bookmarks
wfm on Vista with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a5pre) Gecko/20070519 Minefield/3.0a5pre ID:2007051904 [cairo] i can move bookmarks around (from bookmark manager to toolbar or on different bookmark folders)
(Reporter)

Comment 2

11 years ago
after a restart I get some lines in errorconsole when i reorder a bookmark in Menu or Manager

Warning: reference to undefined property this._controller
Source file: chrome://browser/content/places/menu.xml
Line: 541

Error: folder has no properties
Source file: chrome://browser/content/places/tree.xml
Line: 693
(Reporter)

Comment 3

11 years ago
in Bookmarks Manager I can reorder (drag) a bookmark from one folder to another, providing they are not parent/child

In Bookmarks menu nothing works
Doesn't work here either. Not even with the default set in a freshly created profile.
The same with Vista, also tested with the default set in a new profile.
(Reporter)

Comment 6

11 years ago
Mano, should I file a separate bug for each bookmark part ( Bookmarks Manager - Bookmarks Toolbar - Bookmarks Sidebar - Bookmarks Menu) or simply keep it all together here ?
Flags: blocking-firefox3?
Let's keep it all here for now, thanks Peter.
Assignee: nobody → mano
Priority: -- → P2
Target Milestone: --- → Firefox 3 alpha5
It still worked fine in a 18 December 2006 places build, although some people saw the menu close while dragging (Bug 333602).
Created attachment 265421 [details] [diff] [review]
fix trees
Attachment #265421 - Flags: review?(sspitzer)
(Reporter)

Comment 10

11 years ago
(In reply to comment #9)
> Created an attachment (id=265421) [details]
> fix trees
> 
This fixes the issues in Manager and Sidebar, but not in Bookmarks Menu (can't drag)

This is what I get if I try to drag in Menu:
Warning: reference to undefined property this._controller
Source file: chrome://browser/content/places/menu.xml
Line: 543

Created attachment 265423 [details] [diff] [review]
well, that too

Note that d&d is still kinda buggy (esp. in menus).
Attachment #265421 - Attachment is obsolete: true
Attachment #265423 - Flags: review?(sspitzer)
Attachment #265421 - Flags: review?(sspitzer)

Comment 12

11 years ago
how about bug#380246 ?
dupe ?
(Reporter)

Comment 13

11 years ago
(In reply to comment #11)
> Created an attachment (id=265423) [details]
> well, that too
> 
> Note that d&d is still kinda buggy (esp. in menus).
> 
Yeah I know.
With the changes in menu.xml the Bookmarks Menu d&d is working again.
(Reporter)

Comment 14

11 years ago
(In reply to comment #12)
> how about bug#380246 ?
> dupe ?
> 
It works with the patch of this bug, but I get errors in nsDragAndDrop.js so it's not fully resolving bug 380246
Blocks: 296661
Comment on attachment 265423 [details] [diff] [review]
well, that too

r=sspitzer
Attachment #265423 - Flags: review?(sspitzer) → review+
from irc:

<Mano> the result is kept in the view
<Mano> see getResult()
<Mano> so we first null out the viewer on the result
<Mano> and then null the view
<Mano> this breaks the (very confusing) cycle we've there

can you add that as a comment to the destructor in tree.xml?
Created attachment 265460 [details] [diff] [review]
as checked in
Attachment #265423 - Attachment is obsolete: true
mozilla/browser/components/places/content/menu.xml 1.71
mozilla/browser/components/places/content/tree.xml 1.68
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Flags: blocking-firefox3?
(Reporter)

Updated

11 years ago
Blocks: 380246
I can't drag in the Bookmark menu but then I can't do that in 2.0.0.5 either. Is that a valid scenario?

Dragging in Bookmarks Manager and Sidebar are verified in Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200707270404 Minefield/3.0a7pre though.

Comment 20

11 years ago
(In reply to comment #19)
> I can't drag in the Bookmark menu but then I can't do that in 2.0.0.5 either.
> Is that a valid scenario?
> 
> Dragging in Bookmarks Manager and Sidebar are verified in Mozilla/5.0
> (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200707270404
> Minefield/3.0a7pre though.
> 

Yeah, that's why bug 380301 (which deals with dragging items within the bookmarks menu) is Windows-only. Items aren't supposed to be draggable within Mac menus, I suppose...
I can dnd bookmarks within the menu until I try to do bug 380301, after which it becomes broken.  Restart the browser corrects the broken state.

verified with: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007073005 Minefield/3.0a7pre

we need an entire group of dnd test cases in litmus
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
removing ancient in-testsuite requests
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.